This is an archive of the discontinued LLVM Phabricator instance.

Differential D65570

[test/Object] - Cleanup the Object\obj2yaml.test a bit.
ClosedPublic

Authored by grimar on Aug 1 2019, 4:56 AM.

Details

Reviewers
jhenderson
MaskRay
Commits
rGc92b951567f2: [test/Object] - Cleanup the Object\obj2yaml.test a bit.
rL368044: [test/Object] - Cleanup the Object\obj2yaml.test a bit.
Summary

This makes 2 changes:

  • Removes unwind-section.elf-x86-64 object and the corresponding test case,

because SHT_X86_64_UNWIND is already tested here:
https://github.com/llvm-mirror/llvm/blob/master/test/tools/obj2yaml/section-type.yaml

  • Removes/partially moves "No such file or directory" test, because we already have a similar test here:

https://github.com/llvm-mirror/llvm/blob/master/test/tools/obj2yaml/invalid_input_file.test

Diff Detail

Event Timeline

grimar created this revision.Aug 1 2019, 4:56 AM
jhenderson accepted this revision.Aug 6 2019, 3:02 AM

LGTM.

This revision is now accepted and ready to land.Aug 6 2019, 3:02 AM
Closed by commit rL368044: [test/Object] - Cleanup the Object\obj2yaml.test a bit. (authored by grimar). · Explain WhyAug 6 2019, 7:35 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2019, 7:35 AM

Revision Contents

PathSize
test/
Object/
Inputs/
10 lines
tools/
obj2yaml/
3 lines

Diff 212786

test/Object/Inputs/unwind-section.elf-x86-64

  • This binary file was deleted.

test/Object/obj2yaml.test

Show First 20 Lines • Show All 760 Lines • ▼ Show 20 Lines
# WASM: Name: var # WASM: Name: var
# WASM: SegmentInfo: # WASM: SegmentInfo:
# WASM-NEXT: - Index: 0 # WASM-NEXT: - Index: 0
# WASM-NEXT: Name: .rodata..L.str # WASM-NEXT: Name: .rodata..L.str
# WASM-NEXT: Alignment: 0 # WASM-NEXT: Alignment: 0
# WASM-NEXT: Flags: [ ] # WASM-NEXT: Flags: [ ]
# WASM-NEXT: - Index: 1 # WASM-NEXT: - Index: 1
# WASM: ... # WASM: ...
# RUN: obj2yaml %p/Inputs/unwind-section.elf-x86-64 | FileCheck %s --check-prefix ELF-X86-64-UNWIND
# ELF-X86-64-UNWIND: - Name: .eh_frame
# ELF-X86-64-UNWIND-NEXT: Type: SHT_X86_64_UNWIND
# ELF-X86-64-UNWIND-NEXT: Flags: [ SHF_ALLOC ]
# ELF-X86-64-UNWIND-NEXT: AddressAlign: 0x0000000000000001
# RUN: not obj2yaml %t.blah 2>&1 | FileCheck --check-prefix=ENOENT %s
# ENOENT: Error reading file: {{.*}}.blah: {{[Nn]}}o such file or directory

test/tools/obj2yaml/invalid_input_file.test

# RUN: not obj2yaml %p/path/does/not/exist 2>&1 | FileCheck %s # RUN: not obj2yaml %p/path/does/not/exist 2>&1 | FileCheck %s
# Don't check the OS-dependent message "No such file or directory". # CHECK: Error reading file: {{.*}}/path/does/not/exist: {{[Nn]}}o such file or directory
# CHECK: Error reading file: {{.*}}/path/does/not/exist: {{.*}}