Page MenuHomePhabricator

[OPENMP]Add support for analysis of linear variables and step.
ClosedPublic

Authored by ABataev on Tue, Jul 30, 10:39 AM.

Details

Summary

Added support for basic analysis of the linear variables and linear step
expression. Linear loop iteration variables must be excluded from this
analysis, only non-loop iteration variables must be analyzed.

Diff Detail

Repository
rL LLVM

Event Timeline

ABataev created this revision.Tue, Jul 30, 10:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Jul 30, 10:39 AM
Herald added a subscriber: guansong. · View Herald Transcript
NoQ accepted this revision.Wed, Aug 7, 2:27 PM

Thx again!

lib/AST/OpenMPClause.cpp
473 ↗(On Diff #213888)

Formatting error ^.^

477 ↗(On Diff #213888)

This function name almost makes me slightly uncomfortable -___-"

test/OpenMP/distribute_parallel_for_simd_linear_messages.cpp
9 ↗(On Diff #213888)

I see you guys don't do the // no-warning thing very often? 'Cause even if it's meaningless for VerifyDiagnosticsConsumer, i find it pretty useful when reading other people's tests and trying to figure out what they were about. I.e., if somebody accidentally breaks your machinery and they see a warning on this test, it would be nice if they immediately understand that this is a false positive and they need to go fix their code rather than add an // expected-warning.

This revision is now accepted and ready to land.Wed, Aug 7, 2:27 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptThu, Aug 8, 6:43 AM