Page MenuHomePhabricator

[lldb] Also include the array definition in CommandOptions.inc
ClosedPublic

Authored by teemperor on Jul 26 2019, 6:13 AM.

Details

Summary

Right now our CommandOptions.inc only generates the initializer for the options list but
not the array declaration boilerplate around it. As the array definition is identical for all arrays,
we might as well also let the CommandOptions.inc generate it alongside the initializers.

This patch will also allow us to generate additional declarations related to that option list in
the future (e.g. a enum class representing the specific options which would make our
handling code less prone).

This patch also fixes a few option tables that didn't follow our naming style.

Diff Detail

Repository
rL LLVM

Event Timeline

teemperor created this revision.Jul 26 2019, 6:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 26 2019, 6:13 AM
teemperor edited the summary of this revision. (Show Details)Jul 26 2019, 6:15 AM
This revision is now accepted and ready to land.Jul 26 2019, 9:34 AM
JDevlieghere added inline comments.Jul 26 2019, 1:27 PM
lldb/utils/TableGen/LLDBOptionDefEmitter.cpp
146 ↗(On Diff #211924)

Let's move this before the comment.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2019, 11:24 PM