Page MenuHomePhabricator

[llvm-bcanalyzer] Fixed error 'Expected<T> must be checked before access or destruction'
ClosedPublic

Authored by dendibakh on Jul 17 2019, 2:41 PM.

Details

Reviewers
thegameg
Summary

After rL365286 I had failing test:

LLVM :: tools/gold/X86/v1.12/thinlto_emit_linked_objects.ll

It was failing with the output:

$ llvm-bcanalyzer --dump llvm/test/tools/gold/X86/v1.12/Output/thinlto_emit_linked_objects.ll.tmp3.o.thinlto.bc
Expected<T> must be checked before access or destruction.
Unchecked Expected<T> contained error:
Unexpected end of file reading 0 of 0 bytesStack dump:

Diff Detail

Event Timeline

dendibakh created this revision.Jul 17 2019, 2:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 17 2019, 2:41 PM
thegameg accepted this revision.Jul 17 2019, 2:50 PM

LGTM, thanks! Not sure how I missed this test.

This revision is now accepted and ready to land.Jul 17 2019, 2:50 PM

LGTM, thanks! Not sure how I missed this test.

Can you please double check on your side that it fails without this change?

LGTM, thanks! Not sure how I missed this test.

Can you please double check on your side that it fails without this change?

I don't have a setup where this test is supported, but the error and the fix look pretty obvious to me.

What I meant was that I'm not sure how I missed the bots failing.