Fix broken test suite on Windows after r223091

[ovyalov]

Looks good - thank you for fixing this.

[zturner]

Closed by commit rL223155 (authored by @zturner).

[clayborg]

You will actually want to set this correctly for windows. To find out what settings to use use:

cd test/lang/c/shared_lib
make

Then look for the shared library that was created "libfoo.dll"? If so your setup would be:

elif sys.platform.startswith('windows'):
    cls.platformContext = _PlatformContext('PATH', 'lib', 'dll')

[zturner]

I actually get errors when doing this.

d:\src\llvm\tools\lldb\test\lang\c\shared_lib>make
CC=d:\src\llvm\build\ninja\bin\clang.exe
'g++' is not recognized as an internal or external command,
operable program or batch file.
The system cannot find the file specified.
The system cannot find the file specified.
d:\src\llvm\build\ninja\bin\clang.exe -g -O0 -m32 -fPIC
-Id:/src/llvm/tools/lldb/test/make/../../include -c -o main.o main.c
d:\src\llvm\build\ninja\bin\clang.exe -g -O0 -m32 -fPIC
-Id:/src/llvm/tools/lldb/test/make/../../include -c -o foo.o foo.c
d:\src\llvm\build\ninja\bin\clang.exe -g -O0 -m32 -fPIC
-Id:/src/llvm/tools/lldb/test/make/../../include -fuse-ld=lld foo.o
-shared -o "libfoo.so"
clang.exe: warning: argument unused during compilation: '-shared'
Cannot infer subsystem; assuming /subsystem:console
Undefined symbol: C:\Program Files (x86)\Microsoft Visual Studio
12.0\VC\lib\libcmt.lib(f:\binaries\Intermediate\vctools\crt_bld\SELF_X86\crt\prebuild\build\INTEL\mt_obj\nativec\\crt0.obj):
_main
symbol(s) not found
clang.exe: error: linker command failed with exit code 1 (use -v to see
invocation)
make: *** [libfoo.so] Error 1

This probably hints a deeper issue or just something else I haven't gotten
around to fixing yet (like maybe it's broken for all C files, and only
works for C++).

Just so I understand, is this a location where it's supposed to find system
libraries, like libc or similar? Or is this for something else? Clang is
pretty good about automatically finding all required libraries on Windows,
so if it's just for that it might not be needed, but if it's a place we're
putting our own shared libraries, then maybe we do.

lldb/trunk/test/lldbtest.py

def setUpClass(cls):
                 print >> sys.stderr, "Change dir to:", os.path.join(os.environ["LLDB_TEST"], cls.mydir)
             os.chdir(os.path.join(os.environ["LLDB_TEST"], cls.mydir))
 
         # Set platform context.
         if sys.platform.startswith('darwin'):
             cls.platformContext = _PlatformContext('DYLD_LIBRARY_PATH', 'lib', 'dylib')
         elif sys.platform.startswith('linux') or sys.platform.startswith('freebsd'):
             cls.platformContext = _PlatformContext('LD_LIBRARY_PATH', 'lib', 'so')
+        else:
+            cls.platformContext = None
 
     @classmethod
     def tearDownClass(cls):
         """
         Python unittest framework class teardown fixture.
         Do class-wide cleanup.
         """
 
def setUp(self):
 
         # See addTearDownHook(self, hook) which allows the client to add a hook
         # function to be run during tearDown() time.
         self.hooks = []
 
         # See HideStdout(self).
         self.sys_stdout_hidden = False
 
+        if self.platformContext:
             # set environment variable names for finding shared libraries
             self.dylibPath = self.platformContext.shlib_environment_var
 
     def runHooks(self, child=None, child_prompt=None, use_cmd_api=False):
         """Perform the run hooks to bring lldb debugger to the desired state.
 
         By default, expect a pexpect spawned child and child prompt to be
         supplied (use_cmd_api=False).  If use_cmd_api is true, ignore the child
         and child prompt and use self.runCmd() to run the hooks one by one.
 
class TestBase(Base):
     def registerSharedLibrariesWithTarget(self, target, shlibs):
         '''If we are remotely running the test suite, register the shared libraries with the target so they get uploaded, otherwise do nothing
         
         Any modules in the target that have their remote install file specification set will
         get uploaded to the remote host. This function registers the local copies of the
         shared libraries with the target and sets their remote install locations so they will
         be uploaded when the target is run.
         '''
-        if not shlibs:
+        if not shlibs or not self.platformContext:
             return None
 
         shlib_environment_var = self.platformContext.shlib_environment_var
         shlib_prefix = self.platformContext.shlib_prefix
         shlib_extension = '.' + self.platformContext.shlib_extension
 
         working_dir = self.get_process_working_directory()
         environment = ['%s=%s' % (shlib_environment_var, working_dir)]