This is an archive of the discontinued LLVM Phabricator instance.

Differential D64555

[test/Object, obj2yaml] - Move test cases from test/Object and cleanup.
ClosedPublic

Authored by grimar on Jul 11 2019, 4:03 AM.

Details

Reviewers
jhenderson
MaskRay
Commits
rG75874ca31ef0: [test/Object, obj2yaml] - Move test cases from test/Object and cleanup.
rL365891: [test/Object, obj2yaml] - Move test cases from test/Object and cleanup.
Summary

test/Object is not correct place to have tests that check obj2yaml
functionality, because we have test/tools/obj2yaml folder for that.

In this patch I merged a few test cases with their YAMLs from Inputs
folder, converted one of binary inputs and moved them to
tools/obj2yaml folder.

There are still another tests that might need the same, so it is initial step.
My motivation was that I was able to damage a code responding for dumping/reading
group sections and no tests in yaml2obj/ob2yaml failed, what was really
confusing to see.

Diff Detail

Event Timeline

grimar created this revision.Jul 11 2019, 4:03 AM
grimar edited the summary of this revision. (Show Details)
jhenderson added inline comments.Jul 11 2019, 4:34 AM
test/tools/obj2yaml/invalid-reloc.test
1 ↗(On Diff #209161)

What exactly is broken about the relocation? It's valid for some kinds of relocations to have no symbol.

I think this test needs renaming and the comment updating.

test/tools/obj2yaml/section-group.test
44

Nit: too many spaces between tag and value.

47

Can you get rid of the two section symbols?

MaskRay added a comment.Jul 11 2019, 7:03 AM

I think there are trailing spaces in these YAML files (e.g. in Object/Inputs/COFF/section-aux-symbol.yaml, header: is followed by 10 spaces). When you commit the patch, it might to good to delete them :) D64566

MaskRay added inline comments.Jul 11 2019, 7:14 AM
test/tools/obj2yaml/invalid-reloc.test
1 ↗(On Diff #209161)

asan instrumentation may generate R_*_NONE for debug info. ld -r may generate R_*_NONE. They are used as placeholders when no reasonable relocation is available. In this sense, they are indeed "broken".

However, here it is probably better to say that a symbol index of 0 can be dumped...

grimar marked an inline comment as done.Jul 11 2019, 7:39 AM
grimar added inline comments.
test/tools/obj2yaml/invalid-reloc.test
1 ↗(On Diff #209161)

Yeah. I based my comment on the initial comment (rL293224):

R_X86_64_NONE can be emitted without a symbol associated (well,
in theory it should never be emitted in an ABI-compliant relocatable
object). So, if there's no symbol associated to a reloc, emit one
with an empty name, instead of crashing.

I'll rephrase.

grimar updated this revision to Diff 209448.Jul 12 2019, 3:16 AM
grimar marked 3 inline comments as done.
  • Addressed review comments.
test/tools/obj2yaml/section-group.test
47

Done.

jhenderson accepted this revision.Jul 12 2019, 3:18 AM

LGTM.

This revision is now accepted and ready to land.Jul 12 2019, 3:18 AM
Closed by commit rL365891: [test/Object, obj2yaml] - Move test cases from test/Object and cleanup. (authored by grimar). · Explain WhyJul 12 2019, 3:30 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 12 2019, 3:30 AM

Revision Contents

PathSize
test/
Object/
Inputs/
COFF/
tools/
obj2yaml/
18 lines
49 lines
48 lines
tools/
obj2yaml/
Object/
Inputs/
coff-long-section-name.test/
COFF/
long-section-name.yaml
6 lines
coff-section-aux-symbol.test/
COFF/
section-aux-symbol.yaml
103 lines
coff-weak-external.test/
COFF/
weak-external.yaml
4 lines

Diff 209448

test/Object/Inputs/COFF/long-file-symbol.yaml

  • This file was deleted.
--- !COFF
header:
Machine: IMAGE_FILE_MACHINE_AMD64
Characteristics: [ IMAGE_FILE_RELOCS_STRIPPED, IMAGE_FILE_LINE_NUMS_STRIPPED ]
sections:
symbols:
- Name: .file
Value: 0
SectionNumber: 65534
SimpleType: IMAGE_SYM_TYPE_NULL
ComplexType: IMAGE_SYM_DTYPE_NULL
StorageClass: IMAGE_SYM_CLASS_FILE
File: filename_with_22_chars
...

test/Object/Inputs/COFF/long-section-name.yaml

  • This file was moved to test/tools/obj2yaml/coff-long-section-name.test.

test/Object/Inputs/COFF/section-aux-symbol.yaml

  • This file was moved to test/tools/obj2yaml/coff-section-aux-symbol.test.

test/Object/Inputs/COFF/weak-external.yaml

  • This file was moved to test/tools/obj2yaml/coff-weak-external.test.

test/Object/Inputs/invalid-reloc.elf-x86-64

  • This binary file was deleted.

test/Object/obj2yaml-coff-long-file-symbol.test

  • This file was deleted.
RUN: yaml2obj %p/Inputs/COFF/long-file-symbol.yaml | obj2yaml | FileCheck %s --check-prefix COFF-I386
COFF-I386: File: filename_with_22_chars

test/Object/obj2yaml-coff-long-section-name.test

  • This file was deleted.
RUN: yaml2obj %p/Inputs/COFF/long-section-name.yaml | obj2yaml | FileCheck %s --check-prefix COFF-I386
COFF-I386: Name: .long_section_name

test/Object/obj2yaml-coff-section-aux-symbol.test

  • This file was deleted.
RUN: yaml2obj %p/Inputs/COFF/section-aux-symbol.yaml | obj2yaml | FileCheck %s --check-prefix COFF-I386
COFF-I386: sections:
COFF-I386-NEXT: - Name: .CRT
COFF-I386: symbols:
COFF-I386: - Name: '.CRT$XCAA'
COFF-I386-NEXT: Value: 4
COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
COFF-I386-NEXT: SectionDefinition:
COFF-I386-NEXT: Length: 4
COFF-I386-NEXT: NumberOfRelocations: 1
COFF-I386-NEXT: NumberOfLinenumbers: 0
COFF-I386: - Name: '.CRT$XIAA'
COFF-I386-NEXT: Value: 16
COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
COFF-I386-NEXT: SectionDefinition:
COFF-I386-NEXT: Length: 4
COFF-I386-NEXT: NumberOfRelocations: 1
COFF-I386-NEXT: NumberOfLinenumbers: 0
COFF-I386: - Name: '.CRT$XLD'
COFF-I386-NEXT: Value: 36
COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
COFF-I386-NEXT: SectionDefinition:
COFF-I386-NEXT: Length: 4
COFF-I386-NEXT: NumberOfRelocations: 1
COFF-I386-NEXT: NumberOfLinenumbers: 0
COFF-I386: - Name: '.CRT$XLC'
COFF-I386-NEXT: Value: 32
COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
COFF-I386-NEXT: SectionDefinition:
COFF-I386-NEXT: Length: 4
COFF-I386-NEXT: NumberOfRelocations: 1
COFF-I386-NEXT: NumberOfLinenumbers: 0
COFF-I386: - Name: '.CRT$XDZ'
COFF-I386-NEXT: Value: 48
COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
COFF-I386-NEXT: SectionDefinition:
COFF-I386-NEXT: Length: 4
COFF-I386-NEXT: NumberOfRelocations: 0
COFF-I386-NEXT: NumberOfLinenumbers: 0
COFF-I386: - Name: '.CRT$XDA'
COFF-I386-NEXT: Value: 44
COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
COFF-I386-NEXT: SectionDefinition:
COFF-I386-NEXT: Length: 4
COFF-I386-NEXT: NumberOfRelocations: 0
COFF-I386-NEXT: NumberOfLinenumbers: 0
COFF-I386: - Name: '.CRT$XLZ'
COFF-I386-NEXT: Value: 40
COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
COFF-I386-NEXT: SectionDefinition:
COFF-I386-NEXT: Length: 4
COFF-I386-NEXT: NumberOfRelocations: 0
COFF-I386-NEXT: NumberOfLinenumbers: 0
COFF-I386: - Name: '.CRT$XLA'
COFF-I386-NEXT: Value: 28
COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
COFF-I386-NEXT: SectionDefinition:
COFF-I386-NEXT: Length: 4
COFF-I386-NEXT: NumberOfRelocations: 0
COFF-I386-NEXT: NumberOfLinenumbers: 0
COFF-I386: - Name: '.CRT$XIC'
COFF-I386-NEXT: Value: 20
COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
COFF-I386-NEXT: SectionDefinition:
COFF-I386-NEXT: Length: 4
COFF-I386-NEXT: NumberOfRelocations: 1
COFF-I386-NEXT: NumberOfLinenumbers: 0
COFF-I386: - Name: '.CRT$XCZ'
COFF-I386-NEXT: Value: 8
COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
COFF-I386-NEXT: SectionDefinition:
COFF-I386-NEXT: Length: 4
COFF-I386-NEXT: NumberOfRelocations: 0
COFF-I386-NEXT: NumberOfLinenumbers: 0
COFF-I386: - Name: '.CRT$XCA'
COFF-I386-NEXT: Value: 0
COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
COFF-I386-NEXT: SectionDefinition:
COFF-I386-NEXT: Length: 4
COFF-I386-NEXT: NumberOfRelocations: 0
COFF-I386-NEXT: NumberOfLinenumbers: 0
COFF-I386: - Name: '.CRT$XIZ'
COFF-I386-NEXT: Value: 24
COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
COFF-I386-NEXT: SectionDefinition:
COFF-I386-NEXT: Length: 4
COFF-I386-NEXT: NumberOfRelocations: 0
COFF-I386-NEXT: NumberOfLinenumbers: 0
COFF-I386: - Name: '.CRT$XIA'
COFF-I386-NEXT: Value: 12
COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
COFF-I386-NEXT: SectionDefinition:
COFF-I386-NEXT: Length: 4
COFF-I386-NEXT: NumberOfRelocations: 0
COFF-I386-NEXT: NumberOfLinenumbers: 0

test/Object/obj2yaml-coff-weak-external.test

  • This file was deleted.
RUN: yaml2obj %p/Inputs/COFF/weak-external.yaml | obj2yaml | FileCheck %s --check-prefix COFF-I386
COFF-I386: Characteristics: 0

test/Object/obj2yaml-invalid-reloc.test

  • This file was deleted.
RUN: obj2yaml %p/Inputs/invalid-reloc.elf-x86-64 | FileCheck %s
CHECK: --- !ELF
CHECK-NEXT: FileHeader:
CHECK-NEXT: Class: ELFCLASS64
CHECK-NEXT: Data: ELFDATA2LSB
CHECK-NEXT: OSABI: ELFOSABI_FREEBSD
CHECK-NEXT: Type: ET_REL
CHECK-NEXT: Machine: EM_X86_64
CHECK-NEXT: Sections:
CHECK-NEXT: - Name: .text
CHECK-NEXT: Type: SHT_PROGBITS
CHECK-NEXT: Flags: [ SHF_ALLOC, SHF_EXECINSTR ]
CHECK-NEXT: AddressAlign: 0x0000000000000004
CHECK-NEXT: Content: 4833C0C390
CHECK-NEXT: - Name: .rela.text
CHECK-NEXT: Type: SHT_RELA
CHECK-NEXT: Link: .symtab
CHECK-NEXT: AddressAlign: 0x0000000000000008
CHECK-NEXT: EntSize: 0x0000000000000018
CHECK-NEXT: Info: .text
CHECK-NEXT: Relocations:
CHECK-NEXT: - Offset: 0x0000000000000000
CHECK-NEXT: Symbol: ''
CHECK-NEXT: Type: R_X86_64_NONE
CHECK-NEXT: Symbols:
CHECK-NEXT: - Name: rb_ary_new_capa
CHECK-NEXT: Type: STT_FUNC
CHECK-NEXT: Section: .text
CHECK-NEXT: Size: 0x0000000000000005
CHECK-NEXT: - Name: __dtraceenabled_ruby___array-create
CHECK-NEXT: Index: SHN_ABS
CHECK-NEXT: Binding: STB_GLOBAL
CHECK-NEXT: - Name: '$dtrace1316529.rb_ary_new_capa'
CHECK-NEXT: Type: STT_FUNC
CHECK-NEXT: Section: .text
CHECK-NEXT: Binding: STB_GLOBAL
CHECK-NEXT: Size: 0x0000000000000005
CHECK-NEXT: Visibility: STV_HIDDEN

test/Object/obj2yaml-sectiongroup.test

  • This file was deleted.
# Checks that the tool is able to read section groups with ELF.
RUN: obj2yaml %p/Inputs/sectionGroup.elf.x86-64 > %t1.sectiongroup.yaml
RUN: FileCheck %s --check-prefix ELF-GROUP < %t1.sectiongroup.yaml
RUN: yaml2obj %t1.sectiongroup.yaml -o %t2.o.elf
RUN: llvm-readobj --sections %t2.o.elf | FileCheck %s -check-prefix=SECTIONS
#ELF-GROUP: - Name: .group
#ELF-GROUP: Type: SHT_GROUP
#ELF-GROUP: Link: .symtab
#ELF-GROUP: Info: a
#ELF-GROUP: Members:
#ELF-GROUP: - SectionOrType: GRP_COMDAT
#ELF-GROUP: - SectionOrType: .rodata.a
#SECTIONS: Format: ELF64-x86-64
#SECTIONS: Arch: x86_64
#SECTIONS: AddressSize: 64bit
#SECTIONS: Section {
#SECTIONS: Index: 1
#SECTIONS: Name: .group (21)
#SECTIONS: Type: SHT_GROUP (0x11)
#SECTIONS: Flags [ (0x0)
#SECTIONS: ]
#SECTIONS: Address: 0x0
#SECTIONS: Size: 8
#SECTIONS: AddressAlignment: 4
#SECTIONS: EntrySize: 4
#SECTIONS: }

test/tools/obj2yaml/coff-long-file-symbol.test

  • This file was added.
# RUN: yaml2obj %s | obj2yaml | FileCheck %s --check-prefix COFF-I386
# COFF-I386: File: filename_with_22_chars
--- !COFF
header:
Machine: IMAGE_FILE_MACHINE_AMD64
Characteristics: [ IMAGE_FILE_RELOCS_STRIPPED, IMAGE_FILE_LINE_NUMS_STRIPPED ]
sections:
symbols:
- Name: .file
Value: 0
SectionNumber: 65534
SimpleType: IMAGE_SYM_TYPE_NULL
ComplexType: IMAGE_SYM_DTYPE_NULL
StorageClass: IMAGE_SYM_CLASS_FILE
File: filename_with_22_chars
...

test/tools/obj2yaml/coff-long-section-name.test

  • This file was moved from test/Object/Inputs/COFF/long-section-name.yaml.
# RUN: yaml2obj %s | obj2yaml | FileCheck %s --check-prefix COFF-I386
# COFF-I386: Name: .long_section_name
--- !COFF --- !COFF
header: header:
Machine: IMAGE_FILE_MACHINE_I386 Machine: IMAGE_FILE_MACHINE_I386
Characteristics: [ IMAGE_FILE_RELOCS_STRIPPED, IMAGE_FILE_LINE_NUMS_STRIPPED, IMAGE_FILE_LOCAL_SYMS_STRIPPED, IMAGE_FILE_32BIT_MACHINE ] Characteristics: [ IMAGE_FILE_RELOCS_STRIPPED, IMAGE_FILE_LINE_NUMS_STRIPPED, IMAGE_FILE_LOCAL_SYMS_STRIPPED, IMAGE_FILE_32BIT_MACHINE ]
sections: sections:
- Name: .long_section_name - Name: .long_section_name
Characteristics: [ IMAGE_SCN_CNT_INITIALIZED_DATA, IMAGE_SCN_MEM_READ ] Characteristics: [ IMAGE_SCN_CNT_INITIALIZED_DATA, IMAGE_SCN_MEM_READ ]
Alignment: 1
SectionData: ''
symbols: symbols:
... ...

test/tools/obj2yaml/coff-section-aux-symbol.test

  • This file was moved from test/Object/Inputs/COFF/section-aux-symbol.yaml.
# RUN: yaml2obj %s | obj2yaml | FileCheck %s --check-prefix COFF-I386
# COFF-I386: sections:
# COFF-I386-NEXT: - Name: .CRT
# COFF-I386: symbols:
# COFF-I386: - Name: '.CRT$XCAA'
# COFF-I386-NEXT: Value: 4
# COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
# COFF-I386-NEXT: SectionDefinition:
# COFF-I386-NEXT: Length: 4
# COFF-I386-NEXT: NumberOfRelocations: 1
# COFF-I386-NEXT: NumberOfLinenumbers: 0
# COFF-I386: - Name: '.CRT$XIAA'
# COFF-I386-NEXT: Value: 16
# COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
# COFF-I386-NEXT: SectionDefinition:
# COFF-I386-NEXT: Length: 4
# COFF-I386-NEXT: NumberOfRelocations: 1
# COFF-I386-NEXT: NumberOfLinenumbers: 0
# COFF-I386: - Name: '.CRT$XLD'
# COFF-I386-NEXT: Value: 36
# COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
# COFF-I386-NEXT: SectionDefinition:
# COFF-I386-NEXT: Length: 4
# COFF-I386-NEXT: NumberOfRelocations: 1
# COFF-I386-NEXT: NumberOfLinenumbers: 0
# COFF-I386: - Name: '.CRT$XLC'
# COFF-I386-NEXT: Value: 32
# COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
# COFF-I386-NEXT: SectionDefinition:
# COFF-I386-NEXT: Length: 4
# COFF-I386-NEXT: NumberOfRelocations: 1
# COFF-I386-NEXT: NumberOfLinenumbers: 0
# COFF-I386: - Name: '.CRT$XDZ'
# COFF-I386-NEXT: Value: 48
# COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
# COFF-I386-NEXT: SectionDefinition:
# COFF-I386-NEXT: Length: 4
# COFF-I386-NEXT: NumberOfRelocations: 0
# COFF-I386-NEXT: NumberOfLinenumbers: 0
# COFF-I386: - Name: '.CRT$XDA'
# COFF-I386-NEXT: Value: 44
# COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
# COFF-I386-NEXT: SectionDefinition:
# COFF-I386-NEXT: Length: 4
# COFF-I386-NEXT: NumberOfRelocations: 0
# COFF-I386-NEXT: NumberOfLinenumbers: 0
# COFF-I386: - Name: '.CRT$XLZ'
# COFF-I386-NEXT: Value: 40
# COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
# COFF-I386-NEXT: SectionDefinition:
# COFF-I386-NEXT: Length: 4
# COFF-I386-NEXT: NumberOfRelocations: 0
# COFF-I386-NEXT: NumberOfLinenumbers: 0
# COFF-I386: - Name: '.CRT$XLA'
# COFF-I386-NEXT: Value: 28
# COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
# COFF-I386-NEXT: SectionDefinition:
# COFF-I386-NEXT: Length: 4
# COFF-I386-NEXT: NumberOfRelocations: 0
# COFF-I386-NEXT: NumberOfLinenumbers: 0
# COFF-I386: - Name: '.CRT$XIC'
# COFF-I386-NEXT: Value: 20
# COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
# COFF-I386-NEXT: SectionDefinition:
# COFF-I386-NEXT: Length: 4
# COFF-I386-NEXT: NumberOfRelocations: 1
# COFF-I386-NEXT: NumberOfLinenumbers: 0
# COFF-I386: - Name: '.CRT$XCZ'
# COFF-I386-NEXT: Value: 8
# COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
# COFF-I386-NEXT: SectionDefinition:
# COFF-I386-NEXT: Length: 4
# COFF-I386-NEXT: NumberOfRelocations: 0
# COFF-I386-NEXT: NumberOfLinenumbers: 0
# COFF-I386: - Name: '.CRT$XCA'
# COFF-I386-NEXT: Value: 0
# COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
# COFF-I386-NEXT: SectionDefinition:
# COFF-I386-NEXT: Length: 4
# COFF-I386-NEXT: NumberOfRelocations: 0
# COFF-I386-NEXT: NumberOfLinenumbers: 0
# COFF-I386: - Name: '.CRT$XIZ'
# COFF-I386-NEXT: Value: 24
# COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
# COFF-I386-NEXT: SectionDefinition:
# COFF-I386-NEXT: Length: 4
# COFF-I386-NEXT: NumberOfRelocations: 0
# COFF-I386-NEXT: NumberOfLinenumbers: 0
# COFF-I386: - Name: '.CRT$XIA'
# COFF-I386-NEXT: Value: 12
# COFF-I386: StorageClass: IMAGE_SYM_CLASS_STATIC
# COFF-I386-NEXT: SectionDefinition:
# COFF-I386-NEXT: Length: 4
# COFF-I386-NEXT: NumberOfRelocations: 0
# COFF-I386-NEXT: NumberOfLinenumbers: 0
--- !COFF --- !COFF
header: header:
Machine: IMAGE_FILE_MACHINE_I386 Machine: IMAGE_FILE_MACHINE_I386
Characteristics: [ IMAGE_FILE_RELOCS_STRIPPED, IMAGE_FILE_EXECUTABLE_IMAGE, IMAGE_FILE_LINE_NUMS_STRIPPED, IMAGE_FILE_32BIT_MACHINE, IMAGE_FILE_DEBUG_STRIPPED ] Characteristics: [ IMAGE_FILE_RELOCS_STRIPPED, IMAGE_FILE_EXECUTABLE_IMAGE, IMAGE_FILE_LINE_NUMS_STRIPPED, IMAGE_FILE_32BIT_MACHINE, IMAGE_FILE_DEBUG_STRIPPED ]
sections: sections:
- Name: .CRT - Name: .CRT
Characteristics: [ IMAGE_SCN_CNT_INITIALIZED_DATA, IMAGE_SCN_MEM_READ, IMAGE_SCN_MEM_WRITE ] Characteristics: [ IMAGE_SCN_CNT_INITIALIZED_DATA, IMAGE_SCN_MEM_READ, IMAGE_SCN_MEM_WRITE ]
Alignment: 4 Alignment: 4
SectionData: 0000000030114000000000000000000010104000401640000000000000000000B015400060154000000000000000000000000000 SectionData: 0000000030114000000000000000000010104000401640000000000000000000B015400060154000000000000000000000000000
symbols: symbols:
- Name: '.CRT$XCAA' - Name: '.CRT$XCAA'
Value: 4 Value: 4
SectionNumber: 1 SectionNumber: 1
SimpleType: IMAGE_SYM_TYPE_NULL SimpleType: IMAGE_SYM_TYPE_NULL
ComplexType: IMAGE_SYM_DTYPE_NULL ComplexType: IMAGE_SYM_DTYPE_NULL
StorageClass: IMAGE_SYM_CLASS_STATIC StorageClass: IMAGE_SYM_CLASS_STATIC
SectionDefinition: SectionDefinition:
Length: 4 Length: 4
▲ Show 20 Lines • Show All 149 Lines • Show Last 20 Lines

test/tools/obj2yaml/coff-weak-external.test

  • This file was moved from test/Object/Inputs/COFF/weak-external.yaml.
# RUN: yaml2obj %s | obj2yaml | FileCheck %s --check-prefix COFF-I386
# COFF-I386: Characteristics: 0
--- !COFF --- !COFF
header: header:
Machine: IMAGE_FILE_MACHINE_I386 Machine: IMAGE_FILE_MACHINE_I386
Characteristics: [ IMAGE_FILE_LINE_NUMS_STRIPPED, IMAGE_FILE_32BIT_MACHINE ] Characteristics: [ IMAGE_FILE_LINE_NUMS_STRIPPED, IMAGE_FILE_32BIT_MACHINE ]
sections: sections:
- Name: .text - Name: .text
Characteristics: [ IMAGE_SCN_CNT_CODE, IMAGE_SCN_MEM_EXECUTE, IMAGE_SCN_MEM_READ ] Characteristics: [ IMAGE_SCN_CNT_CODE, IMAGE_SCN_MEM_EXECUTE, IMAGE_SCN_MEM_READ ]
Alignment: 4 Alignment: 4
Show All 35 Lines

test/tools/obj2yaml/no-symbol-reloc.test

  • This file was added.
## Check yaml2obj is able to dump relocations
## that have no or a zero symbol associated.
# RUN: yaml2obj %s -o %t.o
# RUN: obj2yaml %t.o | FileCheck %s
# CHECK: --- !ELF
# CHECK-NEXT: FileHeader:
# CHECK-NEXT: Class: ELFCLASS64
# CHECK-NEXT: Data: ELFDATA2LSB
# CHECK-NEXT: Type: ET_REL
# CHECK-NEXT: Machine: EM_X86_64
# CHECK-NEXT: Sections:
# CHECK-NEXT: - Name: .text
# CHECK-NEXT: Type: SHT_PROGBITS
# CHECK-NEXT: Flags: [ SHF_ALLOC, SHF_EXECINSTR ]
# CHECK-NEXT: - Name: .rela.text
# CHECK-NEXT: Type: SHT_RELA
# CHECK-NEXT: Link: .symtab
# CHECK-NEXT: EntSize: 0x0000000000000018
# CHECK-NEXT: Info: .text
# CHECK-NEXT: Relocations:
# CHECK-NEXT: - Offset: 0x0000000000000000
# CHECK-NEXT: Symbol: ''
# CHECK-NEXT: Type: R_X86_64_NONE
# CHECK-NEXT: - Offset: 0x0000000000000004
# CHECK-NEXT: Symbol: ''
# CHECK-NEXT: Type: R_X86_64_NONE
# CHECK-NEXT: ...
--- !ELF
FileHeader:
Class: ELFCLASS64
Data: ELFDATA2LSB
Type: ET_REL
Machine: EM_X86_64
Sections:
- Name: .text
Type: SHT_PROGBITS
Flags: [ SHF_ALLOC, SHF_EXECINSTR ]
- Name: .rela.text
Type: SHT_RELA
Info: .text
Relocations:
- Offset: 0x0
Type: R_X86_64_NONE
- Offset: 0x4
Type: R_X86_64_NONE
Symbol: 0

test/tools/obj2yaml/section-group.test

  • This file was added.
## Checks that the tool is able to read section groups from ELF.
# RUN: yaml2obj %s > %t1.o
# RUN: llvm-readobj --elf-section-groups %t1.o | FileCheck %s -check-prefix=OBJ
# RUN: obj2yaml %t1.o | FileCheck %s --check-prefix YAML
# OBJ: Groups {
# OBJ-NEXT: Group {
# OBJ-NEXT: Name: .group
# OBJ-NEXT: Index: 1
# OBJ-NEXT: Link: 3
# OBJ-NEXT: Info: 1
# OBJ-NEXT: Type: COMDAT (0x1)
# OBJ-NEXT: Signature: signature
# OBJ-NEXT: Section(s) in group [
# OBJ-NEXT: .rodata (2)
# OBJ-NEXT: ]
# OBJ-NEXT: }
# OBJ-NEXT: }
# YAML: - Name: .group
# YAML: Type: SHT_GROUP
# YAML: Link: .symtab
# YAML: Info: signature
# YAML: Members:
# YAML: - SectionOrType: GRP_COMDAT
# YAML: - SectionOrType: .rodata
--- !ELF
FileHeader:
Class: ELFCLASS64
Data: ELFDATA2LSB
Type: ET_REL
Machine: EM_X86_64
Sections:
- Name: .group
Type: SHT_GROUP
Link: .symtab
Info: signature
Members:
- SectionOrType: GRP_COMDAT
- SectionOrType: .rodata
- Name: .rodata
Type: SHT_PROGBITS
jhendersonUnsubmitted
Done
ReplyInline Actions

Nit: too many spaces between tag and value.

jhenderson: Nit: too many spaces between tag and value.
Symbols:
- Name: signature
Type: STT_OBJECT
jhendersonUnsubmitted
Done
ReplyInline Actions

Can you get rid of the two section symbols?

jhenderson: Can you get rid of the two section symbols?
grimarAuthorUnsubmitted
Done
ReplyInline Actions

Done.

grimar: Done.
Section: .rodata
test/Object/obj2yaml-coff-section-aux-symbol.test