Page MenuHomePhabricator

Fixing modular build issues caused by BitCodes.h
ClosedPublic

Authored by kristina on Jul 9 2019, 8:35 PM.

Details

Summary

Consolidate llvm::BWH_* statics into an enum to fix module build issues. This fixes the LLVM_Bitcode module (getting rid of -Wmodules-ambiguous-internal-linkage).

Diff Detail

Repository
rL LLVM

Event Timeline

kristina created this revision.Jul 9 2019, 8:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2019, 8:35 PM
kristina edited the summary of this revision. (Show Details)Jul 9 2019, 8:44 PM
thegameg accepted this revision.Jul 9 2019, 8:47 PM

LGTM, thanks! Sorry for the breakage!

This revision is now accepted and ready to land.Jul 9 2019, 8:47 PM
This revision was automatically updated to reflect the committed changes.