This is an archive of the discontinued LLVM Phabricator instance.

Fix typo in R_AARCH64_ADR_PREL_PG_HI21
ClosedPublic

Authored by redfast00 on Jul 9 2019, 12:24 PM.

Download Raw Diff

Details

Reviewers

• espindola
MaskRay

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

redfast00 created this revision.Jul 9 2019, 12:24 PM

Herald added a reviewer: • espindola. · View Herald TranscriptJul 9 2019, 12:24 PM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: llvm-commits, MaskRay, kristof.beyls and 3 others. · View Herald Transcript

Looking at ELF/Arch/AArch64.cpp:145: case R_AARCH64_ADR_PREL_PG_HI21: it seems patch is correct. A similar typo is also present at lld/test/ELF/old:22. Can you please also include that in this patch?

Thanks for the finding. Fixed by f9277caffc0a1f311aaba784678c50c6c6b90d75

This revision is now accepted and ready to land.Aug 31 2021, 1:10 PM

MaskRay closed this revision.Aug 31 2021, 1:10 PM

Revision Contents

Path

Size

lld/

test/

ELF/

aarch64-relocs.s

4 lines

Diff 208777

lld/test/ELF/aarch64-relocs.s

	Show All 13 Lines
	# CHECK: Disassembly of section .R_AARCH64_ADR_PREL_LO21:			# CHECK: Disassembly of section .R_AARCH64_ADR_PREL_LO21:
	# CHECK-EMPTY:			# CHECK-EMPTY:
	# CHECK: _start:			# CHECK: _start:
	# CHECK: 0: 21 00 00 10 adr x1, #4			# CHECK: 0: 21 00 00 10 adr x1, #4
	# CHECK: msg:			# CHECK: msg:
	# CHECK: 4:			# CHECK: 4:
	# #4 is the adr immediate value.			# #4 is the adr immediate value.

	.section .R_AARCH64_ADR_PREL_PG_H121,"ax",@progbits			.section .R_AARCH64_ADR_PREL_PG_HI21,"ax",@progbits
	adrp x1,mystr			adrp x1,mystr
	mystr:			mystr:
	.asciz "blah"			.asciz "blah"
	.size mystr, 4			.size mystr, 4

	# S = 0x210012, A = 0x4, P = 0x210012			# S = 0x210012, A = 0x4, P = 0x210012
	# PAGE(S + A) = 0x210000			# PAGE(S + A) = 0x210000
	# PAGE(P) = 0x210000			# PAGE(P) = 0x210000
	#			#
	# CHECK: Disassembly of section .R_AARCH64_ADR_PREL_PG_H121:			# CHECK: Disassembly of section .R_AARCH64_ADR_PREL_PG_HI21:
	# CHECK-EMPTY:			# CHECK-EMPTY:
	# CHECK-NEXT: $x.2:			# CHECK-NEXT: $x.2:
	# CHECK-NEXT: 210012: 01 00 00 90 adrp x1, #0			# CHECK-NEXT: 210012: 01 00 00 90 adrp x1, #0

	.section .R_AARCH64_ADD_ABS_LO12_NC,"ax",@progbits			.section .R_AARCH64_ADD_ABS_LO12_NC,"ax",@progbits
	add x0, x0, :lo12:.L.str			add x0, x0, :lo12:.L.str
	.L.str:			.L.str:
	.asciz "blah"			.asciz "blah"
	▲ Show 20 Lines • Show All 146 Lines • Show Last 20 Lines