This is an archive of the discontinued LLVM Phabricator instance.

Differential D64246

[test/Object/nm-trivial-object.test] - Remove 4 precompiled binaries.
ClosedPublic

Authored by grimar on Jul 5 2019, 6:31 AM.

Details

Reviewers
jhenderson
MaskRay
Commits
rG4e09ef030e0e: [test/Object/nm-trivial-object.test] - Remove 4 precompiled binaries.
rL365601: [test/Object/nm-trivial-object.test] - Remove 4 precompiled binaries.
Summary

This converts 5 precompiled binaries to YAMLs,
removes 4 from inputs and performs a cleanup.

Diff Detail

Repository
rL LLVM

Event Timeline

grimar created this revision.Jul 5 2019, 6:31 AM
Herald added a subscriber: javed.absar. · View Herald TranscriptJul 5 2019, 6:31 AM
grimar added a parent revision: D64206: [llvm\test\Object] - An initial step to cleanup the test cases..Jul 5 2019, 6:31 AM
grimar edited the summary of this revision. (Show Details)
MaskRay added inline comments.Jul 7 2019, 10:12 PM
test/Object/nm-trivial-object.test
88 ↗(On Diff #208166)

What's the difference of textSym1 and textSym2?

grimar marked an inline comment as done.Jul 8 2019, 4:16 AM
grimar added inline comments.
test/Object/nm-trivial-object.test
88 ↗(On Diff #208166)

The intention was the same as for having dataSym1 vs dataSym2: to show that different address is printed for symbols with different values.
That is what original ELF-SEC-ADDR64 test case did I think.

grimar edited the summary of this revision. (Show Details)Jul 8 2019, 10:08 AM
jhenderson accepted this revision.Jul 9 2019, 4:36 AM

LGTM, with one comment.

test/Object/nm-trivial-object.test
80 ↗(On Diff #208166)

A comment describing this test case might be nice. Perhaps "Test different ELF symbols for 64-bit platform."

This revision is now accepted and ready to land.Jul 9 2019, 4:36 AM
grimar retitled this revision from [test/Object/nm-trivial-object.test] - Remove 5 precompiled binaries. to [test/Object/nm-trivial-object.test] - Remove 4 precompiled binaries..Jul 10 2019, 1:37 AM
grimar edited the summary of this revision. (Show Details)

At last moment I found IsNAN.o is used by another test case. I'll keep this object for now.

grimar edited the summary of this revision. (Show Details)Jul 10 2019, 1:39 AM
Closed by commit rL365601: [test/Object/nm-trivial-object.test] - Remove 4 precompiled binaries. (authored by grimar). · Explain WhyJul 10 2019, 1:42 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2019, 1:42 AM

Revision Contents

Diff 208894

llvm/trunk/test/Object/Inputs/absolute.elf-x86-64

  • This is a binary file.

llvm/trunk/test/Object/Inputs/relocatable-with-section-address.elf-x86-64

  • This is a binary file.

llvm/trunk/test/Object/Inputs/thumb-symbols.elf.arm

  • This is a binary file.

llvm/trunk/test/Object/Inputs/weak.elf-x86-64

  • This is a binary file.

llvm/trunk/test/Object/nm-trivial-object.test

Show First 20 Lines • Show All 71 Lines • ▼ Show 20 Lines
# ELF-o: [[FILE]]: 00000000 T main # ELF-o: [[FILE]]: 00000000 T main
# ELF-o: [[FILE]]: U puts # ELF-o: [[FILE]]: U puts
# RUN: llvm-nm -u %t.elf-i386 | FileCheck %s -check-prefix ELF-u # RUN: llvm-nm -u %t.elf-i386 | FileCheck %s -check-prefix ELF-u
# ELF-u: U SomeOtherFunction # ELF-u: U SomeOtherFunction
# ELF-u: U puts # ELF-u: U puts
## Test different ELF symbols for 64-bit platform.
# RUN: yaml2obj -docnum=2 %s > %t.elf-x86-64 # RUN: yaml2obj -docnum=2 %s > %t.elf-x86-64
# RUN: llvm-nm %t.elf-x86-64 | FileCheck %s -check-prefix ELF64 # RUN: llvm-nm %t.elf-x86-64 | FileCheck %s -check-prefix ELF64
# ELF64: U SomeOtherFunction # ELF64: U SomeOtherFunction
# ELF64: 0000000000000000 T main # ELF64: 0000000000000123 a absSym1
# ELF64: U puts # ELF64: 0000000000000123 A absSym2
# ELF64: 0000000000002000 D dataSym1
# ELF64: 0000000000002004 D dataSym2
# ELF64: 0000000000001000 T textSym1
# ELF64: 0000000000001004 T textSym2
# ELF64: U undefinedSym
# ELF64: v weakObject1
# ELF64: 0000000000001000 V weakObject2
# ELF64: w weakSym1
# ELF64: 0000000000001000 W weakSym2
--- !ELF --- !ELF
FileHeader: FileHeader:
Class: ELFCLASS64 Class: ELFCLASS64
Data: ELFDATA2LSB Data: ELFDATA2LSB
Type: ET_REL Type: ET_REL
Machine: EM_X86_64 Machine: EM_X86_64
Sections: Sections:
- Name: .text - Name: .text
Type: SHT_PROGBITS Type: SHT_PROGBITS
Flags: [ SHF_ALLOC, SHF_EXECINSTR ] Flags: [ SHF_ALLOC, SHF_EXECINSTR ]
Address: 0x1000
- Name: .data
Type: SHT_PROGBITS
Flags: [ SHF_ALLOC, SHF_WRITE ]
Address: 0x2000
Symbols: Symbols:
- Name: main - Name: absSym1
Type: STT_FUNC Index: SHN_ABS
Section: .text Value: 0x0000000000000123
- Name: absSym2
Index: SHN_ABS
Binding: STB_GLOBAL Binding: STB_GLOBAL
Size: 0x0000000000000024 Value: 0x0000000000000123
- Name: SomeOtherFunction - Name: SomeOtherFunction
Binding: STB_GLOBAL Binding: STB_GLOBAL
- Name: puts - Name: undefinedSym
Binding: STB_GLOBAL
- Name: weakObject1
Type: STT_OBJECT
Binding: STB_WEAK
- Name: weakObject2
Type: STT_OBJECT
Section: .text
Binding: STB_WEAK
- Name: weakSym1
Binding: STB_WEAK
- Name: weakSym2
Section: .text
Binding: STB_WEAK
- Name: dataSym1
Type: STT_OBJECT
Section: .data
Binding: STB_GLOBAL
Value: 0x0000000000000000
- Name: dataSym2
Type: STT_OBJECT
Section: .data
Binding: STB_GLOBAL
Value: 0x0000000000000004
- Name: textSym1
Type: STT_FUNC
Section: .text
Binding: STB_GLOBAL Binding: STB_GLOBAL
Value: 0x0000000000000000
- Name: textSym2
Type: STT_FUNC
Section: .text
Binding: STB_GLOBAL
Value: 0x0000000000000004
# RUN: llvm-nm %p/Inputs/weak.elf-x86-64 \ ## Test llvm-nm shows all symbols with -a.
# RUN: | FileCheck %s -check-prefix WEAK-ELF64
# WEAK-ELF64: w f1 # RUN: yaml2obj -docnum=3 %s > %t-a.elf-x86-64
# WEAK-ELF64: 0000000000000000 W f2 # RUN: llvm-nm -a %t-a.elf-x86-64 | FileCheck %s -check-prefix ELF64-a
# WEAK-ELF64: v x1
# WEAK-ELF64: 0000000000000000 V x2
# RUN: llvm-nm %p/Inputs/absolute.elf-x86-64 \
# RUN: | FileCheck %s -check-prefix ABSOLUTE-ELF64
# ABSOLUTE-ELF64: 0000000000000123 a a1
# ABSOLUTE-ELF64: 0000000000000123 A a2
# RUN: llvm-nm -a %p/Inputs/IsNAN.o \
# RUN: | FileCheck %s -check-prefix ELF64-DEBUG-SYMS
# ELF64-DEBUG-SYMS: 00000000 b .bss
# ELF64-DEBUG-SYMS-NEXT: 00000000 n .comment
# ELF64-DEBUG-SYMS-NEXT: 00000000 d .data
# ELF64-DEBUG-SYMS-NEXT: 00000000 N .debug_abbrev
# ELF64-DEBUG-SYMS-NEXT: 00000000 N .debug_aranges
# ELF64-DEBUG-SYMS-NEXT: 00000000 N .debug_frame
# ELF64-DEBUG-SYMS-NEXT: 00000000 N .debug_info
# ELF64-DEBUG-SYMS-NEXT: 00000000 N .debug_line
# ELF64-DEBUG-SYMS-NEXT: 00000000 N .debug_pubnames
# ELF64-DEBUG-SYMS-NEXT: 00000000 n .note.GNU-stack
# ELF64-DEBUG-SYMS-NEXT: 00000000 t .text
# ELF64-DEBUG-SYMS-NEXT: 00000000 a IsNAN.cpp
# ELF64-DEBUG-SYMS-NEXT: 00000014 T _ZN4llvm5IsNANEd
# ELF64-DEBUG-SYMS-NEXT: 00000000 T _ZN4llvm5IsNANEf
# ELF64-DEBUG-SYMS-NEXT: U __isnan
# ELF64-DEBUG-SYMS-NEXT: U __isnanf
# RUN: llvm-nm %p/Inputs/relocatable-with-section-address.elf-x86-64 \
# RUN: | FileCheck %s -check-prefix ELF-SEC-ADDR64
## Test that llvm-nm uses addresses even with ELF .o files.
# ELF-SEC-ADDR64: 0000000000000058 D a
# ELF-SEC-ADDR64-NEXT: 000000000000005c D b
# ELF-SEC-ADDR64-NEXT: 0000000000000040 T f
# ELF-SEC-ADDR64-NEXT: 0000000000000050 T g
# ELF-SEC-ADDR64-NEXT: 0000000000000060 D p
# RUN: llvm-nm %p/Inputs/thumb-symbols.elf.arm \ # ELF64-a: 00000000 b .bss
# RUN: | FileCheck %s -check-prefix ELF-THUMB # ELF64-a-NEXT: 00000000 n .comment
# ELF64-a-NEXT: 00000000 d .data
# ELF64-a-NEXT: 00000000 N .debug_sec
# ELF64-a-NEXT: 00000000 t .text
# ELF64-a-NEXT: 00000000 a fileSym
# ELF64-a-NEXT: 00000014 T regularSym
# ELF64-a-NEXT: U undefSym
--- !ELF
FileHeader:
Class: ELFCLASS32
Data: ELFDATA2LSB
Type: ET_REL
Machine: EM_386
Sections:
- Name: .rodata
Type: SHT_PROGBITS
Flags: [ SHF_ALLOC ]
- Name: .text
Type: SHT_PROGBITS
Flags: [ SHF_ALLOC, SHF_EXECINSTR ]
- Name: .data
Type: SHT_PROGBITS
Flags: [ SHF_WRITE, SHF_ALLOC ]
- Name: .bss
Type: SHT_NOBITS
Flags: [ SHF_WRITE, SHF_ALLOC ]
- Name: .debug_sec
Type: SHT_PROGBITS
- Name: .comment
Type: SHT_PROGBITS
Symbols:
- Name: fileSym
Type: STT_FILE
Index: SHN_ABS
- Name: .text
Type: STT_SECTION
Section: .text
- Name: .data
Type: STT_SECTION
Section: .data
- Name: .bss
Type: STT_SECTION
Section: .bss
- Name: .debug_sec
Type: STT_SECTION
Section: .debug_sec
- Name: .comment
Type: STT_SECTION
Section: .comment
- Name: undefSym
Binding: STB_GLOBAL
- Name: regularSym
Type: STT_FUNC
Section: .text
Binding: STB_GLOBAL
Value: 0x0000000000000014
## Test that we drop the thumb bit only from function addresses. ## Test that we drop the thumb bit only from function addresses.
# ELF-THUMB: 00000000 t f
# ELF-THUMB: 00000003 t g # RUN: yaml2obj -docnum=4 %s > %t.elf-arm32
# RUN: llvm-nm %t.elf-arm32 | FileCheck %s -check-prefix ELF-THUMB
# ELF-THUMB: 00000000 t func
# ELF-THUMB: 00000003 t sym
--- !ELF
FileHeader:
Class: ELFCLASS32
Data: ELFDATA2LSB
Type: ET_REL
Machine: EM_ARM
Sections:
- Name: .text
Type: SHT_PROGBITS
Flags: [ SHF_ALLOC, SHF_EXECINSTR ]
Symbols:
- Name: func
Type: STT_FUNC
Section: .text
Value: 0x0000000000000001
- Name: sym
Section: .text
Value: 0x0000000000000003
# RUN: llvm-nm %p/Inputs/trivial-object-test.macho-i386 \ # RUN: llvm-nm %p/Inputs/trivial-object-test.macho-i386 \
# RUN: | FileCheck %s -check-prefix macho # RUN: | FileCheck %s -check-prefix macho
# macho: U _SomeOtherFunction # macho: U _SomeOtherFunction
# macho: 00000000 T _main # macho: 00000000 T _main
# macho: U _puts # macho: U _puts
▲ Show 20 Lines • Show All 110 Lines • Show Last 20 Lines