Page MenuHomePhabricator

[cmake] Don't set install rules for tblgen if building utils is disabled
ClosedPublic

Authored by loladiro on Jul 4 2019, 4:39 PM.

Details

Summary

This is a follow up to D64032. Afterwards if building utils is disabled
and cross compilation is attempted, CMake will complain that adding
install() directives to targets with EXCLUDE_FROM_ALL set is "undefined".
Indeed, it appears depending on the CMake version and the selected
Generator, the install rule will error because the underlying target isn't
built. Fix that by not adding the install rule if building utils is not
requested. Note that this doesn't prevent building tblgen as a
dependency in not cross-build, even if building tools is disabled.

Diff Detail

Repository
rL LLVM

Event Timeline

loladiro created this revision.Jul 4 2019, 4:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 4 2019, 4:39 PM
smeenai accepted this revision.Jul 9 2019, 1:00 PM

LGTM

This revision is now accepted and ready to land.Jul 9 2019, 1:00 PM
This revision was automatically updated to reflect the committed changes.