Page MenuHomePhabricator

[DWARF] Make DWARFDataExtractor possible to be used with both 32- and 64-bit offsets.
AbandonedPublic

Authored by ikudrin on Jul 4 2019, 8:02 AM.

Details

Reviewers
dblaikie
aprantl
Summary

This is a temporary patch to make the transition to 64-bit offsets in DebugInfo/DWARF more smooth.

Diff Detail

Repository
rL LLVM

Event Timeline

ikudrin created this revision.Jul 4 2019, 8:02 AM
Herald added a project: Restricted Project. ยท View Herald TranscriptJul 4 2019, 8:02 AM
aprantl added inline comments.Jul 29 2019, 12:55 PM
include/llvm/DebugInfo/DWARF/DWARFDataExtractor.h
39

I'm surprised that Size is still 32 bits?

probinson added inline comments.
include/llvm/DebugInfo/DWARF/DWARFDataExtractor.h
39

This is the size of the relocated value, and can be no larger than 8; is there some reason to make the type wider?

ikudrin abandoned this revision.Aug 2 2019, 1:39 AM