This is an archive of the discontinued LLVM Phabricator instance.

Differential D63965

[analyzer] exploded-graph-rewriter: Add support for program point tags.
ClosedPublic

Authored by NoQ on Jun 28 2019, 4:26 PM.

Details

Reviewers
Charusso
Commits
rG5a72338bf50e: [analyzer] exploded-graph-rewriter: Implement program point tags.
rL364864: [analyzer] exploded-graph-rewriter: Implement program point tags.
rC364864: [analyzer] exploded-graph-rewriter: Implement program point tags.
Summary

Keep it on a separate line for more visibility.

Diff Detail

Repository
rL LLVM

Event Timeline

NoQ created this revision.Jun 28 2019, 4:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2019, 4:26 PM
Herald added subscribers: cfe-commits, dkrupp, donat.nagy and 6 others. · View Herald Transcript
NoQ mentioned this in D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls.Jun 28 2019, 4:28 PM
Charusso accepted this revision.Jun 28 2019, 4:34 PM

Good idea! Thanks!

This revision is now accepted and ready to land.Jun 28 2019, 4:34 PM
Closed by commit rL364864: [analyzer] exploded-graph-rewriter: Implement program point tags. (authored by NoQ). · Explain WhyJul 1 2019, 4:03 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2019, 4:03 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
cfe/
trunk/
test/
Analysis/
exploded-graph-rewriter/
10 lines
utils/
analyzer/
6 lines

Diff 207428

cfe/trunk/test/Analysis/exploded-graph-rewriter/program_points.dot

Show All 35 Lines
// CHECK-SAME: <td align="left" width="0"> // CHECK-SAME: <td align="left" width="0">
// CHECK-SAME: (main file):<b>4</b>:<b>5</b>: // CHECK-SAME: (main file):<b>4</b>:<b>5</b>:
// CHECK-SAME: </td> // CHECK-SAME: </td>
// CHECK-SAME: <td align="left" width="0"> // CHECK-SAME: <td align="left" width="0">
// CHECK-SAME: <font color="cyan3">DeclRefExpr</font> // CHECK-SAME: <font color="cyan3">DeclRefExpr</font>
// CHECK-SAME: </td> // CHECK-SAME: </td>
// CHECK-SAME: <td>x</td> // CHECK-SAME: <td>x</td>
// CHECK-SAME: </tr> // CHECK-SAME: </tr>
// CHECK-SAME: <tr>
// CHECK-SAME: <td width="0">
// CHECK-SAME: </td>
// CHECK-SAME: <td colspan="2" align="left">
// CHECK-SAME: <b>Tag: </b>
// CHECK-SAME: <font color="crimson">ExprEngine : Clean Node</font>
// CHECK-SAME: </td>
// CHECK-SAME: </tr>
// CHECK-SAME: </table> // CHECK-SAME: </table>
Node0x2 [shape=record,label= Node0x2 [shape=record,label=
"{ "{
{ "node_id": 2, "pointer": "0x2", { "node_id": 2, "pointer": "0x2",
"program_state": null, "program_points": [ "program_state": null, "program_points": [
{ {
"kind": "Statement", "kind": "Statement",
"stmt_kind": "DeclRefExpr", "stmt_kind": "DeclRefExpr",
"stmd_id": 3, "stmd_id": 3,
"pointer": "0x3", "pointer": "0x3",
"pretty": "x", "pretty": "x",
"location": { "location": {
"line": 4, "line": 4,
"column": 5 "column": 5
}, },
"tag": null "tag": "ExprEngine : Clean Node"
} }
]} ]}
\l}"]; \l}"];

cfe/trunk/utils/analyzer/exploded-graph-rewriter.py

Show First 20 Lines • Show All 381 Lines • ▼ Show 20 Lines def visit_program_point(self, p):
% (color, p.kind, p.src_id, p.dst_id)) % (color, p.kind, p.src_id, p.dst_id))
else: else:
# TODO: Print more stuff for other kinds of points. # TODO: Print more stuff for other kinds of points.
self._dump('<tr><td width="0"></td>' self._dump('<tr><td width="0"></td>'
'<td align="left" width="0" colspan="2">' '<td align="left" width="0" colspan="2">'
'<font color="%s">%s</font></td></tr>' '<font color="%s">%s</font></td></tr>'
% (color, p.kind)) % (color, p.kind))
if p.tag is not None:
self._dump('<tr><td width="0"></td>'
'<td colspan="2" align="left">'
'<b>Tag: </b> <font color="crimson">'
'%s</font></td></tr>' % p.tag)
def visit_environment(self, e, prev_e=None): def visit_environment(self, e, prev_e=None):
self._dump('<table border="0">') self._dump('<table border="0">')
def dump_location_context(lc, is_added=None): def dump_location_context(lc, is_added=None):
self._dump('<tr><td>%s</td>' self._dump('<tr><td>%s</td>'
'<td align="left"><b>%s</b></td>' '<td align="left"><b>%s</b></td>'
'<td align="left" colspan="2">' '<td align="left" colspan="2">'
'<font color="grey60">%s </font>' '<font color="grey60">%s </font>'
▲ Show 20 Lines • Show All 236 Lines • Show Last 20 Lines