Page MenuHomePhabricator

ObjC: Squeeze in one more bit for the count of protocols in 'id' types
AcceptedPublic

Authored by jordan_rose on Jun 28 2019, 10:57 AM.

Details

Summary

Someone actually had an Objective-C object pointer type with more than 64 protocols, probably collected through typedefs. Raise the ceiling by one order of magnitude...even though this is just kicking the can down the road, and we need a proper diagnostic for this.

Diff Detail

Repository
rC Clang

Event Timeline

jordan_rose created this revision.Jun 28 2019, 10:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2019, 10:57 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
jfb added a comment.Jul 1 2019, 2:41 PM

DO you have a test for that many protocols? That way when we add a diagnostic we know it won't fail.

jfb accepted this revision.Jul 1 2019, 2:41 PM
This revision is now accepted and ready to land.Jul 1 2019, 2:41 PM

Yeah, I'll write one.