Page MenuHomePhabricator

[benchmark] Disable CMake get_git_version
ClosedPublic

Authored by andrewng on Jun 28 2019, 4:25 AM.

Details

Summary

Disabled CMake get_git_version as it is meaningless for this in-tree
build, and hardcoded a null version.

Not using get_git_version avoids a refresh of the git index that is
executed by get_git_version. Refreshing the index can take a
considerable amount of time if the index needs to be refreshed
(particularly with the mono repo). This situation can arise when
building shared source on a host in VMs.

Diff Detail

Event Timeline

andrewng created this revision.Jun 28 2019, 4:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2019, 4:25 AM
Herald added a subscriber: mgorny. · View Herald Transcript
lebedev.ri accepted this revision.Jun 28 2019, 4:38 AM

Sorry for the delay with the original patch!
I think this is fine.
@kbobyrev - any thoughts?

This revision is now accepted and ready to land.Jun 28 2019, 4:38 AM
kbobyrev accepted this revision.Jun 28 2019, 1:48 PM

The change looks good to me, thank you for the patch!

I think I missed the original discussion regarding some benchmark library changes due to a complete lack of time, apologies for that.

This revision was automatically updated to reflect the committed changes.