Page MenuHomePhabricator

[libFuzzer] Remove too aggressive static_assert in FuzzedDataProvider.
ClosedPublic

Authored by Dor1s on Jun 19 2019, 7:10 AM.

Details

Summary

http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/31

error: static_assert failed due to requirement
'std::numeric_limits<char>::is_signed' "Destination type must be
signed."

static_assert(std::numeric_limits<TS>::is_signed,
^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

/home/buildslave/buildslave/clang-cmake-aarch64-full/llvm/projects/compiler-rt/lib/fuzzer/utils/FuzzedDataProvider.h:126:19:
note: in instantiation of function template specialization
'FuzzedDataProvider::ConvertUnsignedToSigned<char, unsigned char>'
requested here

char next = ConvertUnsignedToSigned<char>(data_ptr_[0]);
            ^

1 error generated.

Diff Detail

Repository
rL LLVM

Event Timeline

Dor1s created this revision.Jun 19 2019, 7:10 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 19 2019, 7:10 AM
Herald added subscribers: llvm-commits, Restricted Project, delcypher and 2 others. · View Herald Transcript
Dor1s accepted this revision.Jun 19 2019, 7:10 AM

Self-approval for a minor fix.

This revision is now accepted and ready to land.Jun 19 2019, 7:10 AM
This revision was automatically updated to reflect the committed changes.