Page MenuHomePhabricator

[analyzer] exploded-graph-rewriter: Fix escaping and unescaping of StringRegions.
ClosedPublic

Authored by NoQ on Jun 18 2019, 3:00 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

NoQ created this revision.Jun 18 2019, 3:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 18 2019, 3:00 PM
Charusso accepted this revision.Jun 18 2019, 3:09 PM
Charusso marked an inline comment as done.

Thanks!

clang/lib/StaticAnalyzer/Core/RegionStore.cpp
222 ↗(On Diff #205444)

Could you inject /*AddQuotes=*/?

clang/test/Analysis/exploded-graph-rewriter/escapes.c
3 ↗(On Diff #205444)

I like that styling.

clang/utils/analyzer/exploded-graph-rewriter.py
287 ↗(On Diff #205444)

I think this is the correct approach.

This revision is now accepted and ready to land.Jun 18 2019, 3:09 PM
NoQ updated this revision to Diff 205449.Jun 18 2019, 3:16 PM

Oh, right, thanks!

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2019, 4:32 PM