Python 3: decode string as utf-8 to avoid type mismatch.

[aprantl]

Summary

Side question: do we need to do this on every subprocess.check_output() in this file?

rdar://problem/51464644

[davide]

yes.

[JDevlieghere]

Yep, we should decode all the check_output results, as they may contain unicode.

[aprantl]

Address review feedback.

[JDevlieghere]

LGTM!

lldb/trunk/examples/python/crashlog.py

try:
     # Just try for LLDB in case PYTHONPATH is already correctly setup
     import lldb
 except ImportError:
     lldb_python_dirs = list()
     # lldb is not in the PYTHONPATH, try some defaults for the current platform
     platform_system = platform.system()
     if platform_system == 'Darwin':
         # On Darwin, try the currently selected Xcode directory
-        xcode_dir = subprocess.check_output("xcode-select --print-path", shell=True)
+        xcode_dir = subprocess.check_output("xcode-select --print-path", shell=True).decode("utf-8")
         if xcode_dir:
             lldb_python_dirs.append(
                 os.path.realpath(
                     xcode_dir +
                     '/../SharedFrameworks/LLDB.framework/Resources/Python'))
             lldb_python_dirs.append(
                 xcode_dir + '/Library/PrivateFrameworks/LLDB.framework/Resources/Python')
         lldb_python_dirs.append(
class Frame:
             print("%s%s" % (prefix, str(self)))
 
     class DarwinImage(symbolication.Image):
         """Class that represents a binary images in a darwin crash log"""
         dsymForUUIDBinary = '/usr/local/bin/dsymForUUID'
         if not os.path.exists(dsymForUUIDBinary):
             try:
                 dsymForUUIDBinary = subprocess.check_output('which dsymForUUID',
-                                                            shell=True).rstrip('\n')
+                                                            shell=True).decode("utf-8").rstrip('\n')
             except:
                 dsymForUUIDBinary = ""
 
         dwarfdump_uuid_regex = re.compile(
             'UUID: ([-0-9a-fA-F]+) \(([^\(]+)\) .*')
 
         def __init__(
                 self,
class DarwinImage(symbolication.Image):
             # Mark this as resolved so we don't keep trying
             self.resolved = True
             uuid_str = self.get_normalized_uuid_string()
             if self.show_symbol_progress():
                 print('Getting symbols for %s %s...' % (uuid_str, self.path), end=' ')
             if os.path.exists(self.dsymForUUIDBinary):
                 dsym_for_uuid_command = '%s %s' % (
                     self.dsymForUUIDBinary, uuid_str)
-                s = subprocess.check_output(dsym_for_uuid_command, shell=True)
+                s = subprocess.check_output(dsym_for_uuid_command, shell=True).decode("utf-8")
                 if s:
                     try:
                         plist_root = read_plist(s)
                     except:
                         print(("Got exception: ", sys.exc_info()[1], " handling dsymForUUID output: \n", s))
                         raise
                     if plist_root:
                         plist = plist_root[uuid_str]
class DarwinImage(symbolication.Image):
                                 self.resolved_path = self.path
             if not self.resolved_path and os.path.exists(self.path):
                 if not self.find_matching_slice():
                     return False
             if not self.resolved_path and not os.path.exists(self.path):
                 try:
                     dsym = subprocess.check_output(
                         ["/usr/bin/mdfind",
-                         "com_apple_xcode_dsym_uuids == %s"%uuid_str])[:-1]
+                         "com_apple_xcode_dsym_uuids == %s"%uuid_str]).decode("utf-8")[:-1]
                     if dsym and os.path.exists(dsym):
                         print(('falling back to binary inside "%s"'%dsym))
                         self.symfile = dsym
                         dwarf_dir = os.path.join(dsym, 'Contents/Resources/DWARF')
                         for filename in os.listdir(dwarf_dir):
                             self.path = os.path.join(dwarf_dir, filename)
                             if not self.find_matching_slice():
                                 return False
if target:
                     'Process:         %s [%u]\n' %
                     (identifier, pid))
         out_file.write('Path:            %s\n' % (target.executable.fullpath))
         out_file.write('Identifier:      %s\n' % (identifier))
         out_file.write('\nDate/Time:       %s\n' %
                        (datetime.datetime.now().strftime("%Y-%m-%d %H:%M:%S")))
         out_file.write(
             'OS Version:      Mac OS X %s (%s)\n' %
-            (platform.mac_ver()[0], subprocess.check_output('sysctl -n kern.osversion', shell=True)))
+            (platform.mac_ver()[0], subprocess.check_output('sysctl -n kern.osversion', shell=True).decode("utf-8")))
         out_file.write('Report Version:  9\n')
         for thread_idx in range(process.num_threads):
             thread = process.thread[thread_idx]
             out_file.write('\nThread %u:\n' % (thread_idx))
             for (frame_idx, frame) in enumerate(thread.frames):
                 frame_pc = frame.pc
                 frame_offset = 0
                 if frame.function: