Page MenuHomePhabricator

Python 3: decode string as utf-8 to avoid type mismatch.
ClosedPublic

Authored by aprantl on Jun 13 2019, 6:23 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

aprantl created this revision.Jun 13 2019, 6:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2019, 6:24 PM
JDevlieghere requested changes to this revision.Jun 13 2019, 11:08 PM

Yep, we should decode all the check_output results, as they may contain unicode.

This revision now requires changes to proceed.Jun 13 2019, 11:08 PM
aprantl updated this revision to Diff 204772.Jun 14 2019, 8:30 AM

Address review feedback.

This revision is now accepted and ready to land.Jun 14 2019, 8:35 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2019, 8:37 AM