This is an archive of the discontinued LLVM Phabricator instance.

Differential D63250

[LLD] [MinGW] Support the --subsystem=val option in joined form
ClosedPublic

Authored by mstorsjo on Jun 13 2019, 3:49 AM.

Details

Reviewers
ruiu
rnk
Commits
rGff4e0a9f3e4a: [MinGW] Support the --subsystem=val option in joined form
rLLD363433: [MinGW] Support the --subsystem=val option in joined form
rL363433: [MinGW] Support the --subsystem=val option in joined form
Summary

It would be nice to refactor MinGW/Options.td to use the same kind of multiclass option defines as in ELF/Options.td. I'll try to keep that in mind to look at later at some point maybe.

Diff Detail

Event Timeline

mstorsjo created this revision.Jun 13 2019, 3:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2019, 3:49 AM
ruiu accepted this revision.Jun 14 2019, 6:31 AM

LGTM

This revision is now accepted and ready to land.Jun 14 2019, 6:31 AM
Closed by commit rL363433: [MinGW] Support the --subsystem=val option in joined form (authored by mstorsjo). · Explain WhyJun 14 2019, 10:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
MinGW/
1 line
test/
MinGW/
2 lines

Diff 204478

MinGW/Options.td

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Lines
def no_gc_sections: F<"no-gc-sections">, HelpText<"Don't remove unused sections">; def no_gc_sections: F<"no-gc-sections">, HelpText<"Don't remove unused sections">;
def o: JoinedOrSeparate<["-"], "o">, MetaVarName<"<path>">, def o: JoinedOrSeparate<["-"], "o">, MetaVarName<"<path>">,
HelpText<"Path to file to write output">; HelpText<"Path to file to write output">;
def out_implib: Separate<["--"], "out-implib">, HelpText<"Import library name">; def out_implib: Separate<["--"], "out-implib">, HelpText<"Import library name">;
def out_implib_eq: Joined<["--"], "out-implib=">, Alias<out_implib>; def out_implib_eq: Joined<["--"], "out-implib=">, Alias<out_implib>;
def output_def: S<"output-def">, HelpText<"Output def file">; def output_def: S<"output-def">, HelpText<"Output def file">;
def shared: F<"shared">, HelpText<"Build a shared object">; def shared: F<"shared">, HelpText<"Build a shared object">;
def subs: S<"subsystem">, HelpText<"Specify subsystem">; def subs: S<"subsystem">, HelpText<"Specify subsystem">;
def subs_eq: J<"subsystem=">, Alias<subs>;
def stack: S<"stack">; def stack: S<"stack">;
def strip_all: F<"strip-all">, def strip_all: F<"strip-all">,
HelpText<"Omit all symbol information from the output binary">; HelpText<"Omit all symbol information from the output binary">;
def strip_debug: F<"strip-debug">, def strip_debug: F<"strip-debug">,
HelpText<"Omit all debug information, but keep symbol information">; HelpText<"Omit all debug information, but keep symbol information">;
def undefined: S<"u">, def undefined: S<"u">,
HelpText<"Include symbol in the link, if available">; HelpText<"Include symbol in the link, if available">;
def undefined_long: S<"undefined">, Alias<undefined>; def undefined_long: S<"undefined">, Alias<undefined>;
▲ Show 20 Lines • Show All 46 Lines • Show Last 20 Lines

test/MinGW/driver.test

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Lines
RUN: ld.lld -### foo.o -m i386pep --entry bar | FileCheck -check-prefix=ENTRY %s RUN: ld.lld -### foo.o -m i386pep --entry bar | FileCheck -check-prefix=ENTRY %s
ENTRY: -entry:bar ENTRY: -entry:bar
RUN: ld.lld -### foo.o -m i386pep -mllvm bar -mllvm baz | FileCheck -check-prefix=MLLVM %s RUN: ld.lld -### foo.o -m i386pep -mllvm bar -mllvm baz | FileCheck -check-prefix=MLLVM %s
MLLVM: -mllvm:bar -mllvm:baz MLLVM: -mllvm:bar -mllvm:baz
RUN: ld.lld -### foo.o -m i386pep -subsystem console | FileCheck -check-prefix=SUBSYSTEM %s RUN: ld.lld -### foo.o -m i386pep -subsystem console | FileCheck -check-prefix=SUBSYSTEM %s
RUN: ld.lld -### foo.o -m i386pep --subsystem console | FileCheck -check-prefix=SUBSYSTEM %s RUN: ld.lld -### foo.o -m i386pep --subsystem console | FileCheck -check-prefix=SUBSYSTEM %s
RUN: ld.lld -### foo.o -m i386pep -subsystem=console | FileCheck -check-prefix=SUBSYSTEM %s
RUN: ld.lld -### foo.o -m i386pep --subsystem=console | FileCheck -check-prefix=SUBSYSTEM %s
SUBSYSTEM: -subsystem:console SUBSYSTEM: -subsystem:console
RUN: ld.lld -### foo.o -m i386pep --major-os-version 7 --minor-os-version 8 | FileCheck -check-prefix=SUBSYSTEM_VERSION %s RUN: ld.lld -### foo.o -m i386pep --major-os-version 7 --minor-os-version 8 | FileCheck -check-prefix=SUBSYSTEM_VERSION %s
RUN: ld.lld -### foo.o -m i386pep --major-subsystem-version 7 --minor-subsystem-version 8 | FileCheck -check-prefix=SUBSYSTEM_VERSION %s RUN: ld.lld -### foo.o -m i386pep --major-subsystem-version 7 --minor-subsystem-version 8 | FileCheck -check-prefix=SUBSYSTEM_VERSION %s
RUN: ld.lld -### foo.o -m i386pep --major-os-version=7 --minor-os-version=8 --major-subsystem-version=7 --minor-subsystem-version=8 | FileCheck -check-prefix=SUBSYSTEM_VERSION %s RUN: ld.lld -### foo.o -m i386pep --major-os-version=7 --minor-os-version=8 --major-subsystem-version=7 --minor-subsystem-version=8 | FileCheck -check-prefix=SUBSYSTEM_VERSION %s
SUBSYSTEM_VERSION: -subsystem:default,7.8 SUBSYSTEM_VERSION: -subsystem:default,7.8
RUN: ld.lld -### foo.o -m i386pep --minor-subsystem-version 8 | FileCheck -check-prefix=SUBSYSTEM_DEFAULT_MAJOR %s RUN: ld.lld -### foo.o -m i386pep --minor-subsystem-version 8 | FileCheck -check-prefix=SUBSYSTEM_DEFAULT_MAJOR %s
▲ Show 20 Lines • Show All 133 Lines • Show Last 20 Lines