This is an archive of the discontinued LLVM Phabricator instance.

[clang] Fixing incorrect implicit deduction guides (PR41549)
ClosedPublic

Authored by Tyker on Jun 10 2019, 3:11 AM.

Details

Summary

bug report

Before this patch, implicit deduction guides were generated from the first declaration found by lookup.
With this patch implicit deduction guides are generated from the definition of the class template.
Also added test that was previously failing.

Diff Detail

Repository
rL LLVM

Event Timeline

Tyker created this revision.Jun 10 2019, 3:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2019, 3:11 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
rsmith added inline comments.Jun 10 2019, 8:35 AM
clang/test/SemaCXX/cxx1z-class-template-argument-deduction.cpp
503 ↗(On Diff #203789)

Should this be using CTAD?

Tyker updated this revision to Diff 203862.Jun 10 2019, 11:03 AM

fixed the issue.

Tyker marked an inline comment as done.Jun 10 2019, 11:03 AM
rsmith accepted this revision.Jun 10 2019, 4:04 PM

Thanks!

This revision is now accepted and ready to land.Jun 10 2019, 4:04 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2019, 1:38 AM