This is an archive of the discontinued LLVM Phabricator instance.

Add cdb test for global constants
ClosedPublic

Authored by akhuang on Jun 6 2019, 12:35 PM.

Details

Summary

This creates an integration test for global constants

Diff Detail

Repository
rL LLVM

Event Timeline

akhuang created this revision.Jun 6 2019, 12:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2019, 12:35 PM
rnk accepted this revision.Jun 6 2019, 12:47 PM

lgtm

This should be running here now:
http://lab.llvm.org:8011/builders/clang-x64-windows-msvc
I'd suggest checking if it's green tomorrow.

debuginfo-tests/win_cdb/global-constant.cpp
27–28 ↗(On Diff #203419)

Please add a comment indicating why this is intended behavior. ENUM_POS is unused, so it never ends up in the globals stream, so we expect this to fail.

This revision is now accepted and ready to land.Jun 6 2019, 12:47 PM
akhuang updated this revision to Diff 203431.Jun 6 2019, 1:15 PM
  • add comment
This revision was automatically updated to reflect the committed changes.