This is an archive of the discontinued LLVM Phabricator instance.

Differential D62782

Fix -Wdouble-promotion warnings.
ClosedPublic

Authored by brucem on Jun 1 2019, 10:50 AM.

Details

Reviewers
mclow.lists
Commits
rGba41d3b1fd68: Fix -Wdouble-promotion warnings.
rCXX364798: Fix -Wdouble-promotion warnings.
rL364798: Fix -Wdouble-promotion warnings.

Diff Detail

Repository
rL LLVM

Event Timeline

brucem created this revision.Jun 1 2019, 10:50 AM
Herald added subscribers: ldionne, christof. · View Herald TranscriptJun 1 2019, 10:50 AM
Harbormaster completed remote builds in B32775: Diff 202564.Jun 1 2019, 10:53 AM
mclow.lists added a comment.Jun 3 2019, 6:55 AM

This looks fine to me; but where were you getting these warnings?

brucem added a comment.Jun 4 2019, 8:00 AM

I'd modified CMakeLists.txt to add -Wdouble-promotion and removed this line: -Wno-double-promotion # FIXME: remove me ...

mclow.lists accepted this revision.Jul 1 2019, 8:58 AM

Sorry for the slow response.

This revision is now accepted and ready to land.Jul 1 2019, 8:58 AM
Closed by commit rL364798: Fix -Wdouble-promotion warnings. (authored by brucem). · Explain WhyJul 1 2019, 9:13 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2019, 9:13 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
libcxx/
trunk/
include/
2 lines
4 lines

Diff 207345

libcxx/trunk/include/limits

Show First 20 Lines • Show All 403 Lines • ▼ Show 20 Linesprotected:
_LIBCPP_INLINE_VISIBILITY static _LIBCPP_CONSTEXPR type min() _NOEXCEPT {return __LDBL_MIN__;} _LIBCPP_INLINE_VISIBILITY static _LIBCPP_CONSTEXPR type min() _NOEXCEPT {return __LDBL_MIN__;}
_LIBCPP_INLINE_VISIBILITY static _LIBCPP_CONSTEXPR type max() _NOEXCEPT {return __LDBL_MAX__;} _LIBCPP_INLINE_VISIBILITY static _LIBCPP_CONSTEXPR type max() _NOEXCEPT {return __LDBL_MAX__;}
_LIBCPP_INLINE_VISIBILITY static _LIBCPP_CONSTEXPR type lowest() _NOEXCEPT {return -max();} _LIBCPP_INLINE_VISIBILITY static _LIBCPP_CONSTEXPR type lowest() _NOEXCEPT {return -max();}
static _LIBCPP_CONSTEXPR const bool is_integer = false; static _LIBCPP_CONSTEXPR const bool is_integer = false;
static _LIBCPP_CONSTEXPR const bool is_exact = false; static _LIBCPP_CONSTEXPR const bool is_exact = false;
static _LIBCPP_CONSTEXPR const int radix = __FLT_RADIX__; static _LIBCPP_CONSTEXPR const int radix = __FLT_RADIX__;
_LIBCPP_INLINE_VISIBILITY static _LIBCPP_CONSTEXPR type epsilon() _NOEXCEPT {return __LDBL_EPSILON__;} _LIBCPP_INLINE_VISIBILITY static _LIBCPP_CONSTEXPR type epsilon() _NOEXCEPT {return __LDBL_EPSILON__;}
_LIBCPP_INLINE_VISIBILITY static _LIBCPP_CONSTEXPR type round_error() _NOEXCEPT {return 0.5;} _LIBCPP_INLINE_VISIBILITY static _LIBCPP_CONSTEXPR type round_error() _NOEXCEPT {return 0.5L;}
static _LIBCPP_CONSTEXPR const int min_exponent = __LDBL_MIN_EXP__; static _LIBCPP_CONSTEXPR const int min_exponent = __LDBL_MIN_EXP__;
static _LIBCPP_CONSTEXPR const int min_exponent10 = __LDBL_MIN_10_EXP__; static _LIBCPP_CONSTEXPR const int min_exponent10 = __LDBL_MIN_10_EXP__;
static _LIBCPP_CONSTEXPR const int max_exponent = __LDBL_MAX_EXP__; static _LIBCPP_CONSTEXPR const int max_exponent = __LDBL_MAX_EXP__;
static _LIBCPP_CONSTEXPR const int max_exponent10 = __LDBL_MAX_10_EXP__; static _LIBCPP_CONSTEXPR const int max_exponent10 = __LDBL_MAX_10_EXP__;
static _LIBCPP_CONSTEXPR const bool has_infinity = true; static _LIBCPP_CONSTEXPR const bool has_infinity = true;
static _LIBCPP_CONSTEXPR const bool has_quiet_NaN = true; static _LIBCPP_CONSTEXPR const bool has_quiet_NaN = true;
▲ Show 20 Lines • Show All 398 Lines • Show Last 20 Lines

libcxx/trunk/include/utility

Show First 20 Lines • Show All 1,473 Lines • ▼ Show 20 Lines
template <> template <>
struct _LIBCPP_TEMPLATE_VIS hash<float> struct _LIBCPP_TEMPLATE_VIS hash<float>
: public __scalar_hash<float> : public __scalar_hash<float>
{ {
_LIBCPP_INLINE_VISIBILITY _LIBCPP_INLINE_VISIBILITY
size_t operator()(float __v) const _NOEXCEPT size_t operator()(float __v) const _NOEXCEPT
{ {
// -0.0 and 0.0 should return same hash // -0.0 and 0.0 should return same hash
if (__v == 0.0) if (__v == 0.0f)
return 0; return 0;
return __scalar_hash<float>::operator()(__v); return __scalar_hash<float>::operator()(__v);
} }
}; };
template <> template <>
struct _LIBCPP_TEMPLATE_VIS hash<double> struct _LIBCPP_TEMPLATE_VIS hash<double>
: public __scalar_hash<double> : public __scalar_hash<double>
Show All 11 Lines
template <> template <>
struct _LIBCPP_TEMPLATE_VIS hash<long double> struct _LIBCPP_TEMPLATE_VIS hash<long double>
: public __scalar_hash<long double> : public __scalar_hash<long double>
{ {
_LIBCPP_INLINE_VISIBILITY _LIBCPP_INLINE_VISIBILITY
size_t operator()(long double __v) const _NOEXCEPT size_t operator()(long double __v) const _NOEXCEPT
{ {
// -0.0 and 0.0 should return same hash // -0.0 and 0.0 should return same hash
if (__v == 0.0) if (__v == 0.0L)
return 0; return 0;
#if defined(__i386__) #if defined(__i386__)
// Zero out padding bits // Zero out padding bits
union union
{ {
long double __t; long double __t;
struct struct
{ {
▲ Show 20 Lines • Show All 104 Lines • Show Last 20 Lines