Page MenuHomePhabricator

Revert "D11003: Tolerate DWARF compile unit without filename."
ClosedPublic

Authored by labath on May 28 2019, 4:57 AM.

Details

Summary

This code is modifying a support file list after it has been created.
This makes it hard to share the file list between type units and
compile units in DWARF. It's not a total showstopper, but supporting
this while also sharing the lists would make things more complicated.

Given that this was added to support a project which never fully
materialised, and that even back then there were some concerns about the
correctness of this approach (according to D11003#200772 the compile
unit name is not guaranteed to be the first one in the support file
list), I think we should just delete this workaround.

Diff Detail

Repository
rLLDB LLDB

Event Timeline

labath created this revision.May 28 2019, 4:57 AM
clayborg accepted this revision.May 28 2019, 7:06 AM

As long as we put an empty FileSpec at the start of the support list we are ok. All file indexes are 1 based.

This revision is now accepted and ready to land.May 28 2019, 7:06 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 29 2019, 4:26 AM