Page MenuHomePhabricator

[LibTooling] Add Explanation parameter to `makeRule`.
ClosedPublic

Authored by ymandel on May 24 2019, 7:06 AM.

Details

Summary

Conceptually, a single-case RewriteRule has a matcher, edit(s) and an (optional)
explanation. makeRule previously only took the matcher and edit(s). This
change adds (optional) support for the explanation.

Diff Detail

Repository
rL LLVM

Event Timeline

ymandel created this revision.May 24 2019, 7:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2019, 7:06 AM
ilya-biryukov accepted this revision.May 24 2019, 7:33 AM

LGTM. Much nicer now!

This revision is now accepted and ready to land.May 24 2019, 7:33 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2019, 8:09 AM