This is an archive of the discontinued LLVM Phabricator instance.

[PR41567][Sema] Fixed cast kind in addr space conversions
ClosedPublic

Authored by Anastasia on May 23 2019, 3:30 AM.

Reviewers

Commits

Summary

This change sets missing cast kind correctly in the address space conversion case.

Seems reasonable.

This revision is now accepted and ready to land.May 29 2019, 9:21 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

Sema/

4 lines

test/

CodeGenOpenCLCXX/

7 lines

Show First 20 Lines • Show All 2,422 Lines • ▼ Show 20 Lines	if (isValidCast(tcr))
Kind = CK_NoOp;		Kind = CK_NoOp;

Sema::CheckedConversionKind CCK =		Sema::CheckedConversionKind CCK =
FunctionalStyle ? Sema::CCK_FunctionalCast : Sema::CCK_CStyleCast;		FunctionalStyle ? Sema::CCK_FunctionalCast : Sema::CCK_CStyleCast;
if (tcr == TC_NotApplicable) {		if (tcr == TC_NotApplicable) {
tcr = TryAddressSpaceCast(Self, SrcExpr, DestType, /CStyle/ true, msg);		tcr = TryAddressSpaceCast(Self, SrcExpr, DestType, /CStyle/ true, msg);
if (SrcExpr.isInvalid())		if (SrcExpr.isInvalid())
return;		return;

		if (isValidCast(tcr))
		Kind = CK_AddressSpaceConversion;

if (tcr == TC_NotApplicable) {		if (tcr == TC_NotApplicable) {
// ... or if that is not possible, a static_cast, ignoring const, ...		// ... or if that is not possible, a static_cast, ignoring const, ...
tcr = TryStaticCast(Self, SrcExpr, DestType, CCK, OpRange, msg, Kind,		tcr = TryStaticCast(Self, SrcExpr, DestType, CCK, OpRange, msg, Kind,
BasePath, ListInitialization);		BasePath, ListInitialization);
if (SrcExpr.isInvalid())		if (SrcExpr.isInvalid())
return;		return;

if (tcr == TC_NotApplicable) {		if (tcr == TC_NotApplicable) {
▲ Show 20 Lines • Show All 390 Lines • Show Last 20 Lines

				// RUN: %clang_cc1 %s -triple spir-unknown-unknown -cl-std=c++ -emit-llvm -O0 -o - \| FileCheck %s

				void bar(__generic volatile unsigned int* ptr)
				{
				//CHECK: addrspacecast i32 addrspace(4)* %{{.+}} to i32 addrspace(1)*
				auto gptr = (__global volatile unsigned int*)ptr;
				}