This is an archive of the discontinued LLVM Phabricator instance.

Differential D62069

[NFC][InstSImplify] Fix flip-flopped comments and test names
ClosedPublic

Authored by cameron.mcinally on May 17 2019, 9:50 AM.

Details

Reviewers
echristo
spatel
Commits
rZORG573e9545c781: [NFC][InstSImplify] Fix flip-flopped comments and test names
rG573e9545c781: [NFC][InstSImplify] Fix flip-flopped comments and test names
rG19dc8c728046: [NFC][InstSImplify] Fix flip-flopped comments and test names
rL361057: [NFC][InstSImplify] Fix flip-flopped comments and test names

Diff Detail

Repository
rL LLVM

Event Timeline

cameron.mcinally created this revision.May 17 2019, 9:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2019, 9:50 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
spatel accepted this revision.May 17 2019, 10:22 AM

LGTM - feel free to make NFC test improvements without pre-commit review.

This revision is now accepted and ready to land.May 17 2019, 10:22 AM
Closed by commit rL361057: [NFC][InstSImplify] Fix flip-flopped comments and test names (authored by mcinally). · Explain WhyMay 17 2019, 11:02 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
test/
Transforms/
InstSimplify/
12 lines

Diff 200064

llvm/trunk/test/Transforms/InstSimplify/floating-point-arithmetic.ll

Show All 40 Lines
; CHECK-LABEL: @fsub_-0_-0_x_vec_undef_elts( ; CHECK-LABEL: @fsub_-0_-0_x_vec_undef_elts(
; CHECK-NEXT: ret <2 x float> [[A:%.*]] ; CHECK-NEXT: ret <2 x float> [[A:%.*]]
; ;
%t1 = fsub <2 x float> <float undef, float -0.0>, %a %t1 = fsub <2 x float> <float undef, float -0.0>, %a
%ret = fsub <2 x float> <float -0.0, float undef>, %t1 %ret = fsub <2 x float> <float -0.0, float undef>, %t1
ret <2 x float> %ret ret <2 x float> %ret
} }
; fsub 0.0, (fsub -0.0, X) != X ; fsub -0.0, (fsub 0.0, X) != X
define float @fsub_0_-0_x(float %a) { define float @fsub_-0_0_x(float %a) {
; CHECK-LABEL: @fsub_0_-0_x( ; CHECK-LABEL: @fsub_-0_0_x(
; CHECK-NEXT: [[T1:%.*]] = fsub float 0.000000e+00, [[A:%.*]] ; CHECK-NEXT: [[T1:%.*]] = fsub float 0.000000e+00, [[A:%.*]]
; CHECK-NEXT: [[RET:%.*]] = fsub float -0.000000e+00, [[T1]] ; CHECK-NEXT: [[RET:%.*]] = fsub float -0.000000e+00, [[T1]]
; CHECK-NEXT: ret float [[RET]] ; CHECK-NEXT: ret float [[RET]]
; ;
%t1 = fsub float 0.0, %a %t1 = fsub float 0.0, %a
%ret = fsub float -0.0, %t1 %ret = fsub float -0.0, %t1
ret float %ret ret float %ret
} }
; fsub -0.0, (fsub 0.0, X) != X ; fsub 0.0, (fsub -0.0, X) != X
define float @fsub_-0_0_x(float %a) { define float @fsub_0_-0_x(float %a) {
; CHECK-LABEL: @fsub_-0_0_x( ; CHECK-LABEL: @fsub_0_-0_x(
; CHECK-NEXT: [[T1:%.*]] = fsub float -0.000000e+00, [[A:%.*]] ; CHECK-NEXT: [[T1:%.*]] = fsub float -0.000000e+00, [[A:%.*]]
; CHECK-NEXT: [[RET:%.*]] = fsub float 0.000000e+00, [[T1]] ; CHECK-NEXT: [[RET:%.*]] = fsub float 0.000000e+00, [[T1]]
; CHECK-NEXT: ret float [[RET]] ; CHECK-NEXT: ret float [[RET]]
; ;
%t1 = fsub float -0.0, %a %t1 = fsub float -0.0, %a
%ret = fsub float 0.0, %t1 %ret = fsub float 0.0, %t1
ret float %ret ret float %ret
} }
▲ Show 20 Lines • Show All 1,207 Lines • Show Last 20 Lines