Page MenuHomePhabricator

[AST] const-ify ObjC inherited class search

Authored by modocache on May 16 2019, 2:47 PM.



When writing an AST matcher to find inherited Objective-C classes, I
noticed the returned ObjCInterfaceDecl* was mutable. It doesn't seem
like it needs to be mutable, so this patch makes it const.

Patch by Adam Ernst.

Diff Detail

Event Timeline

modocache created this revision.May 16 2019, 2:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2019, 2:47 PM
adamjernst added a subscriber: adamjernst.

@beng (hello!!) I've spotted you reviewing some Objective-C clang stuff … can you review, or do you have advice on a qualified reviewer?

beng edited reviewers, added: jyknight; removed: beng.May 28 2019, 10:26 AM
beng added a subscriber: benhamilton.
beng added a subscriber: beng.

Thanks! @jyknight might want to take a look (this seems fine to me though).

I don't really have much to say about this, and the patch is probably fine, but I do note that most of the other accessors on this class also return mutable objects.

modocache abandoned this revision.Nov 21 2019, 7:40 PM

I'm not super interested in this patch anymore, someone else feel free to work on this! :)