This is an archive of the discontinued LLVM Phabricator instance.

[LLD] [MinGW] Implement the -v and --version flags for the MinGW driver
ClosedPublic

Authored by mstorsjo on May 16 2019, 1:32 PM.

Diff Detail

Event Timeline

mstorsjo created this revision.May 16 2019, 1:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2019, 1:32 PM
ruiu added inline comments.May 16 2019, 6:39 PM
MinGW/Driver.cpp
144

Do we need "(compatible with GNU linkers)"? This is a hack for compatibility with configure scripts (https://www.sigbus.info/software-compatibility-and-our-own-user-agent-problem). I don't know much about how linkers are detected on Windows for MinGW, but if you don't need it, you can remove it from the version message.

mstorsjo marked an inline comment as done.May 16 2019, 11:13 PM
mstorsjo added inline comments.
MinGW/Driver.cpp
144

One of the main selling points of MinGW is that it works with the same configure/autotools/libtool based builds as lots of unix libraries. So yes, unfortunately, the same compatibility hack is needed here as well. Do you want me to bring along a bit more of the comment to point this out, to indicate that this is intentional?

mstorsjo updated this revision to Diff 199980.May 16 2019, 11:30 PM

Added more of the original comment about "compatible with GNU linkers" which also applies for MinGW.

ruiu accepted this revision.May 17 2019, 3:07 AM

LGTM

This revision is now accepted and ready to land.May 17 2019, 3:07 AM
This revision was automatically updated to reflect the committed changes.