This is an archive of the discontinued LLVM Phabricator instance.

[ASan] Fix zero_page_pc test for PowerPC
ClosedPublic

Authored by foad on Nov 7 2014, 8:29 AM.

Details

Summary

In the Power architecture, all branch instructions ignore the 2 least
significant bits of the target address. Consequently if you branch to an
invalid address, the address reported along with the SIGSEGV will have
been rounded down to a multiple of 4. Tweak this test accordingly.

This may fix the test for ARM too, in which case we could remove
the XFAIL, but I have no way of testing that.

Diff Detail

Event Timeline

foad updated this revision to Diff 15923.Nov 7 2014, 8:29 AM
foad retitled this revision from to [ASan] Fix zero_page_pc test for PowerPC.
foad updated this object.
foad edited the test plan for this revision. (Show Details)
foad added reviewers: kcc, samsonov, willschm.
foad added a subscriber: Unknown Object (MLST).
foad added a reviewer: glider.Nov 7 2014, 8:31 AM
foad updated this object.
samsonov accepted this revision.Nov 7 2014, 11:34 AM
samsonov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Nov 7 2014, 11:34 AM
foad closed this revision.Nov 7 2014, 12:52 PM