Page MenuHomePhabricator

[lldb] Add MacroQualified switch cases for r360109

Authored by krasimir on May 7 2019, 5:41 AM.



r360109 added a new enum case, causing lldb build to fail with several errors like:
lldb/source/Symbol/ClangASTContext.cpp:4342:11: error: enumeration value 'MacroQualified' not handled in switch [-Werror,-Wswitch]

switch (qual_type->getTypeClass()) {

This adds the missing switch cases.
I'm not an lldb maintainer and just used my best judgement that it's probably expected that we break in these cases. Feel free to ping / revert / fix this change if this behavior is not appropriate.

Diff Detail


Event Timeline

krasimir created this revision.May 7 2019, 5:41 AM
krasimir edited the summary of this revision. (Show Details)May 7 2019, 5:45 AM
krasimir added a reviewer: gribozavr.
gribozavr accepted this revision.May 7 2019, 6:29 AM
This revision is now accepted and ready to land.May 7 2019, 6:29 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 7 2019, 6:57 AM