Enable standard so versioning for libLLVM.

[beanz]

Summary

This resolves Bugzilla bug 15493.

[chapuni]

Looks good. Although I could accept this, excuse me to sit here to listen in more opinions.

I wish this logic into llvm_add_library(). Versioning may be general among shared libs. I will do in future.

FYI, autoconf's --enable-shared emits the library like libLLVM-3.6.0svn.so.

In llvm-shlib/Makefile;

LIBRARYNAME = LLVM-$(LLVM_VERSION_MAJOR).$(LLVM_VERSION_MINOR)$(LLVM_VERSION_SUFFIX)
LIBRARYALIASNAME = LLVM-$(LLVMVersion)

In Makefile.config;

LLVMVersion       := 3.6.0svn
LLVM_VERSION_MAJOR := 3
LLVM_VERSION_MINOR := 6
LLVM_VERSION_PATCH := 0
LLVM_VERSION_SUFFIX := svn

To which way shall we follow?

[beanz]

I think you are right, and that is a better way to handle this problem. I'll work on updated patches. I'll also add the LLVM_VERSION_SUFFIX to match the autotools implementation so that we have parity.

[beanz]

Moved the so versioning support into llvm_add_library so that it applies to all shared libraries, not just libLLVM.

[beanz]

Ping?

[pete]

Updated patch LGTM.

tools/llvm-shlib/CMakeLists.txt

add_custom_command(OUTPUT ${LLVM_EXPORTED_SYMBOL_FILE}
     COMMENT "Generating combined export list...")
 
 endif()
 
 add_llvm_library(LLVM SHARED ${SOURCES})
 
 add_dependencies(LLVM ${LLVM_EXPORTED_SYMBOL_FILE})
 
+set_target_properties(LLVM PROPERTIES
+     SOVERSION ${LLVM_VERSION_MAJOR}
+     VERSION ${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH})
+
 if (APPLE)
   set_property(TARGET LLVM APPEND_STRING PROPERTY
               LINK_FLAGS
               " -compatibility_version ${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR} -current_version ${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}")
 endif()