This is an archive of the discontinued LLVM Phabricator instance.

[CUDA] Do not pass deprecated option fo fatbinary
ClosedPublic

Authored by tra on May 2 2019, 3:02 PM.

Reviewers

Commits

Summary

CUDA 10.1 tools have deprecated some command line options, so fatbinary no longer needs --cuda parameter.

tra created this revision.May 2 2019, 3:02 PM

This revision is now accepted and ready to land.May 2 2019, 3:32 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

Driver/

ToolChains/

3 lines

Show First 20 Lines • Show All 448 Lines • ▼ Show 20 Lines	void NVPTX::Linker::ConstructJob(Compilation &C, const JobAction &JA,
const InputInfoList &Inputs,		const InputInfoList &Inputs,
const ArgList &Args,		const ArgList &Args,
const char *LinkingOutput) const {		const char *LinkingOutput) const {
const auto &TC =		const auto &TC =
static_cast<const toolchains::CudaToolChain &>(getToolChain());		static_cast<const toolchains::CudaToolChain &>(getToolChain());
assert(TC.getTriple().isNVPTX() && "Wrong platform");		assert(TC.getTriple().isNVPTX() && "Wrong platform");

ArgStringList CmdArgs;		ArgStringList CmdArgs;
		if (TC.CudaInstallation.version() <= CudaVersion::CUDA_100)
CmdArgs.push_back("--cuda");		CmdArgs.push_back("--cuda");
CmdArgs.push_back(TC.getTriple().isArch64Bit() ? "-64" : "-32");		CmdArgs.push_back(TC.getTriple().isArch64Bit() ? "-64" : "-32");
CmdArgs.push_back(Args.MakeArgString("--create"));		CmdArgs.push_back(Args.MakeArgString("--create"));
CmdArgs.push_back(Args.MakeArgString(Output.getFilename()));		CmdArgs.push_back(Args.MakeArgString(Output.getFilename()));
if (mustEmitDebugInfo(Args) == EmitSameDebugInfoAsHost)		if (mustEmitDebugInfo(Args) == EmitSameDebugInfoAsHost)
CmdArgs.push_back("-g");		CmdArgs.push_back("-g");

for (const auto& II : Inputs) {		for (const auto& II : Inputs) {
auto *A = II.getAction();		auto *A = II.getAction();
▲ Show 20 Lines • Show All 418 Lines • Show Last 20 Lines