This is an archive of the discontinued LLVM Phabricator instance.

gn build: Update TODO now that libcxx libcxxabi libunwind clang-tools-extra are done
ClosedPublic

Authored by thakis on May 2 2019, 2:32 PM.

Reviewers

phosek
EricWF

Commits

Herald added a project: Restricted Project. · View Herald Transcript

LGTM although we're still missing tests for libunwind, libcxxabi and libcxx.

This revision is now accepted and ready to land.May 3 2019, 3:19 PM

Thanks!

Are you going to work on those tests?

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

utils/

gn/

3 lines

	Ideas for things to do:			Ideas for things to do:

	- more projects (compiler-rt libcxx libcxxabi libunwind clang-tools-extra lldb)			- more projects (compiler-rt's asan/ubsan/msan/tsan, lldb)
	- phosek expressed interest in compiler-rt libcxx libcxxabi libunwind
	- once there are more projects, have an llvm_enable_projects arg, modeled			- once there are more projects, have an llvm_enable_projects arg, modeled
	after llvm_targets_to_build in the GN build			after llvm_targets_to_build in the GN build
	- a check-all build target that runs test of all projects			- a check-all build target that runs test of all projects
	- more targets (AVR MIPS RISCV SystemZ etc)			- more targets (AVR MIPS RISCV SystemZ etc)
	- example: https://reviews.llvm.org/D56416			- example: https://reviews.llvm.org/D56416
	- investigate feasibility of working `gn check`			- investigate feasibility of working `gn check`

	- "optimized tblgen" mode			- "optimized tblgen" mode
	Show All 14 Lines