This is an archive of the discontinued LLVM Phabricator instance.

Differential D6141

[mips64] Fix MIPS64 exception personality encoding.
ClosedPublic

Authored by vstefanovic on Nov 5 2014, 12:43 PM.

Details

Reviewers
joerg
petarj
Commits
rG391584055863: Merging r221408: --------------------------------------------------------------…
rG35f05747f3c2: [mips64] Fix MIPS64 exception personality encoding
rL221408: [mips64] Fix MIPS64 exception personality encoding
Summary

Remove dynamic relocations of __gxx_personality_v0 from the .eh_frame.
The MIPS64 follow-up of the MIPS32 fix (rL209907).

Diff Detail

Event Timeline

vstefanovic updated this revision to Diff 15826.Nov 5 2014, 12:43 PM
vstefanovic retitled this revision from to [mips64] Fix MIPS64 exception personality encoding..
vstefanovic updated this object.
vstefanovic edited the test plan for this revision. (Show Details)
vstefanovic added reviewers: joerg, petarj.
vstefanovic set the repository for this revision to rL LLVM.
vstefanovic added a subscriber: Unknown Object (MLST).
joerg accepted this revision.Nov 5 2014, 1:31 PM
joerg edited edge metadata.

LGTM

This revision is now accepted and ready to land.Nov 5 2014, 1:31 PM
petarj closed this revision.Nov 5 2014, 2:53 PM
petarj updated this revision to Diff 15835.
petarj edited edge metadata.

Closed by commit rL221408 (authored by @petarj).

Revision Contents

PathSize
lib/
MC/
2 lines
test/
CodeGen/
Mips/
15 lines

Diff 15826

lib/MC/MCObjectFileInfo.cpp

Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Lines
} else { } else {
PersonalityEncoding = dwarf::DW_EH_PE_absptr; PersonalityEncoding = dwarf::DW_EH_PE_absptr;
LSDAEncoding = dwarf::DW_EH_PE_absptr; LSDAEncoding = dwarf::DW_EH_PE_absptr;
TTypeEncoding = dwarf::DW_EH_PE_absptr; TTypeEncoding = dwarf::DW_EH_PE_absptr;
} }
break; break;
case Triple::mips: case Triple::mips:
case Triple::mipsel: case Triple::mipsel:
case Triple::mips64:
case Triple::mips64el:
// MIPS uses indirect pointer to refer personality functions, so that the // MIPS uses indirect pointer to refer personality functions, so that the
// eh_frame section can be read-only. DW.ref.personality will be generated // eh_frame section can be read-only. DW.ref.personality will be generated
// for relocation. // for relocation.
PersonalityEncoding = dwarf::DW_EH_PE_indirect; PersonalityEncoding = dwarf::DW_EH_PE_indirect;
break; break;
case Triple::ppc64: case Triple::ppc64:
case Triple::ppc64le: case Triple::ppc64le:
PersonalityEncoding = dwarf::DW_EH_PE_indirect | dwarf::DW_EH_PE_pcrel | PersonalityEncoding = dwarf::DW_EH_PE_indirect | dwarf::DW_EH_PE_pcrel |
▲ Show 20 Lines • Show All 91 Lines • Show Last 20 Lines

test/CodeGen/Mips/ehframe-indirect.ll

; RUN: llc -mtriple=mipsel-linux-gnu < %s | FileCheck %s ; RUN: llc -mtriple=mipsel-linux-gnu < %s | FileCheck -check-prefix=CHECK32 %s
; RUN: llc -mtriple=mipsel-linux-android < %s | FileCheck %s ; RUN: llc -mtriple=mipsel-linux-android < %s | FileCheck -check-prefix=CHECK32 %s
; RUN: llc -mtriple=mips64el-linux-gnu < %s | FileCheck -check-prefix=CHECK64 %s
; RUN: llc -mtriple=mips64el-linux-android < %s | FileCheck -check-prefix=CHECK64 %s
define i32 @main() { define i32 @main() {
; CHECK: .cfi_startproc ; CHECK: .cfi_startproc
; CHECK: .cfi_personality 128, DW.ref.__gxx_personality_v0 ; CHECK: .cfi_personality 128, DW.ref.__gxx_personality_v0
entry: entry:
invoke void @foo() to label %cont unwind label %lpad invoke void @foo() to label %cont unwind label %lpad
; CHECK: foo ; CHECK: foo
Show All 11 Lines
declare i32 @__gxx_personality_v0(...) declare i32 @__gxx_personality_v0(...)
declare void @foo() declare void @foo()
; CHECK: .hidden DW.ref.__gxx_personality_v0 ; CHECK: .hidden DW.ref.__gxx_personality_v0
; CHECK: .weak DW.ref.__gxx_personality_v0 ; CHECK: .weak DW.ref.__gxx_personality_v0
; CHECK: .section .data.DW.ref.__gxx_personality_v0,"aGw",@progbits,DW.ref.__gxx_personality_v0,comdat ; CHECK: .section .data.DW.ref.__gxx_personality_v0,"aGw",@progbits,DW.ref.__gxx_personality_v0,comdat
; CHECK: .align 2 ; CHECK32: .align 2
; CHECK64: .align 3
; CHECK: .type DW.ref.__gxx_personality_v0,@object ; CHECK: .type DW.ref.__gxx_personality_v0,@object
; CHECK: .size DW.ref.__gxx_personality_v0, 4 ; CHECK32: .size DW.ref.__gxx_personality_v0, 4
; CHECK64: .size DW.ref.__gxx_personality_v0, 8
; CHECK: DW.ref.__gxx_personality_v0: ; CHECK: DW.ref.__gxx_personality_v0:
; CHECK: .4byte __gxx_personality_v0 ; CHECK32: .4byte __gxx_personality_v0
; CHECK64: .8byte __gxx_personality_v0