This is an archive of the discontinued LLVM Phabricator instance.

Fix inconsistency in calculating DIAG_START values
ClosedPublic

Authored by russell.gallop on Apr 29 2019, 7:43 AM.

Download Raw Diff

Details

Reviewers

xazax.hun
rsmith

Commits

rGa7c2e580c7a6: Fix inconsistency in calculating DIAG_START_ values.
rC359558: Fix inconsistency in calculating DIAG_START_ values.
rL359558: Fix inconsistency in calculating DIAG_START_ values.

Summary

The inconsistency was introduced at r313975. As DIAG_SIZE_CROSSTU and DIAG_SIZE_COMMENT are both 100 this should be NFC.

Diff Detail

Repository: rL LLVM

Event Timeline

russell.gallop created this revision.Apr 29 2019, 7:43 AM

Herald added a subscriber: rnkovacs. · View Herald TranscriptApr 29 2019, 7:43 AM

LGTM! Thanks for the fix.

This revision is now accepted and ready to land.Apr 29 2019, 5:38 PM

Closed by commit rL359558: Fix inconsistency in calculating DIAG_START_ values. (authored by russell_gallop). · Explain WhyApr 30 2019, 5:52 AM

This revision was automatically updated to reflect the committed changes.

Herald added a project: Restricted Project. · View Herald TranscriptApr 30 2019, 5:52 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

Path

Size

cfe/

trunk/

include/

clang/

Basic/

DiagnosticIDs.h

4 lines

Diff 197304

cfe/trunk/include/clang/Basic/DiagnosticIDs.h

Show First 20 Lines • Show All 44 Lines • ▼ Show 20 Lines	enum {
DIAG_START_COMMON = 0,		DIAG_START_COMMON = 0,
DIAG_START_DRIVER = DIAG_START_COMMON + DIAG_SIZE_COMMON,		DIAG_START_DRIVER = DIAG_START_COMMON + DIAG_SIZE_COMMON,
DIAG_START_FRONTEND = DIAG_START_DRIVER + DIAG_SIZE_DRIVER,		DIAG_START_FRONTEND = DIAG_START_DRIVER + DIAG_SIZE_DRIVER,
DIAG_START_SERIALIZATION = DIAG_START_FRONTEND + DIAG_SIZE_FRONTEND,		DIAG_START_SERIALIZATION = DIAG_START_FRONTEND + DIAG_SIZE_FRONTEND,
DIAG_START_LEX = DIAG_START_SERIALIZATION + DIAG_SIZE_SERIALIZATION,		DIAG_START_LEX = DIAG_START_SERIALIZATION + DIAG_SIZE_SERIALIZATION,
DIAG_START_PARSE = DIAG_START_LEX + DIAG_SIZE_LEX,		DIAG_START_PARSE = DIAG_START_LEX + DIAG_SIZE_LEX,
DIAG_START_AST = DIAG_START_PARSE + DIAG_SIZE_PARSE,		DIAG_START_AST = DIAG_START_PARSE + DIAG_SIZE_PARSE,
DIAG_START_COMMENT = DIAG_START_AST + DIAG_SIZE_AST,		DIAG_START_COMMENT = DIAG_START_AST + DIAG_SIZE_AST,
DIAG_START_CROSSTU = DIAG_START_COMMENT + DIAG_SIZE_CROSSTU,		DIAG_START_CROSSTU = DIAG_START_COMMENT + DIAG_SIZE_COMMENT,
DIAG_START_SEMA = DIAG_START_CROSSTU + DIAG_SIZE_COMMENT,		DIAG_START_SEMA = DIAG_START_CROSSTU + DIAG_SIZE_CROSSTU,
DIAG_START_ANALYSIS = DIAG_START_SEMA + DIAG_SIZE_SEMA,		DIAG_START_ANALYSIS = DIAG_START_SEMA + DIAG_SIZE_SEMA,
DIAG_START_REFACTORING = DIAG_START_ANALYSIS + DIAG_SIZE_ANALYSIS,		DIAG_START_REFACTORING = DIAG_START_ANALYSIS + DIAG_SIZE_ANALYSIS,
DIAG_UPPER_LIMIT = DIAG_START_REFACTORING + DIAG_SIZE_REFACTORING		DIAG_UPPER_LIMIT = DIAG_START_REFACTORING + DIAG_SIZE_REFACTORING
};		};

class CustomDiagInfo;		class CustomDiagInfo;

/// All of the diagnostics that can be emitted by the frontend.		/// All of the diagnostics that can be emitted by the frontend.
▲ Show 20 Lines • Show All 279 Lines • Show Last 20 Lines