Page MenuHomePhabricator

Fix inconsistency in calculating DIAG_START values
ClosedPublic

Authored by russell.gallop on Apr 29 2019, 7:43 AM.

Details

Summary

The inconsistency was introduced at r313975. As DIAG_SIZE_CROSSTU and DIAG_SIZE_COMMENT are both 100 this should be NFC.

Diff Detail

Repository
rL LLVM

Event Timeline

russell.gallop created this revision.Apr 29 2019, 7:43 AM
xazax.hun accepted this revision.EditedApr 29 2019, 5:38 PM

LGTM! Thanks for the fix.

This revision is now accepted and ready to land.Apr 29 2019, 5:38 PM
Closed by commit rL359558: Fix inconsistency in calculating DIAG_START_ values. (authored by russell_gallop, committed by ). · Explain WhyApr 30 2019, 5:52 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 30 2019, 5:52 AM