Page MenuHomePhabricator

[hexagon] change AsmParser assertion to error
AcceptedPublic

Authored by bcain on Apr 25 2019, 8:17 AM.

Details

Reviewers
sidneym
kparzysz
Summary

For immediates that can't be evaluated in assembler-mapped instructions, we
should return 'invalid operand' instead of assert.

Diff Detail

Event Timeline

bcain created this revision.Apr 25 2019, 8:17 AM
bcain updated this revision to Diff 196666.Apr 25 2019, 10:03 AM

Added context lines.

bcain added a comment.Apr 30 2019, 2:52 PM

ping? any comments/concerns?

kparzysz accepted this revision.May 3 2019, 9:30 AM
kparzysz added inline comments.
llvm/test/MC/Hexagon/inval_immed.s
4

Please add spaces around =.

This revision is now accepted and ready to land.May 3 2019, 9:30 AM