Page MenuHomePhabricator

[lldb] Use local definition of get_cpuid_count
ClosedPublic

Authored by JosephTremoulet on Apr 23 2019, 1:18 PM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptApr 23 2019, 1:18 PM

@labath, as discussed in D59991, I went with a local copy of the function since I didn't see an obvious opportunity to tweak the calling code, but maybe I overlooked something. My copy of cpuid.h matches https://github.com/gcc-mirror/gcc/blob/gcc-5-branch/gcc/config/i386/cpuid.h

labath accepted this revision.Apr 24 2019, 12:17 AM

The chosen approach looks fine to me. The only nit I have is that llvm style prefers static functions over ones in anonymous namespaces (though this file is not very consistent in that aspect already).

Do you have commit access or shall I commit this for you?

This revision is now accepted and ready to land.Apr 24 2019, 12:17 AM
  • Use static function rather than anonymous namespace

Switched to static function, and yes I do have commit access. Thanks for the review!

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 24 2019, 10:58 AM