[LLD] [MinGW] Add an --appcontainer flag, passed through to lld-link

[mstorsjo]

Summary

GNU ld doesn't have such a flag though, so this is an lld specific option.

[ruiu]

LGTM

I'm curious what kind of application you want to use this option for.

[mstorsjo]

In D60860#1472628, @ruiu wrote:

LGTM

I'm curious what kind of application you want to use this option for.

When building DLLs for UWP/WinStore/WinRT, this flag needs to be set, afaik.

Since GNU ld doesn't support the flag, VLC used to set it with a perl script for editing binaries and setting the flag. :-) https://code.videolan.org/videolan/vlc-winrt/blob/master/libvlc/appcontainer.pl

lld/trunk/MinGW/Driver.cpp

bool mingw::link(ArrayRef<const char *> ArgsArr, raw_ostream &Diag) {
   if (Args.hasArg(OPT_exclude_all_symbols))
     Add("-exclude-all-symbols");
   if (Args.hasArg(OPT_export_all_symbols))
     Add("-export-all-symbols");
   if (Args.hasArg(OPT_large_address_aware))
     Add("-largeaddressaware");
   if (Args.hasArg(OPT_kill_at))
     Add("-kill-at");
+  if (Args.hasArg(OPT_appcontainer))
+    Add("-appcontainer");
 
   if (Args.getLastArgValue(OPT_m) != "thumb2pe" &&
       Args.getLastArgValue(OPT_m) != "arm64pe" && !Args.hasArg(OPT_dynamicbase))
     Add("-dynamicbase:no");
 
   if (Args.hasFlag(OPT_no_insert_timestamp, OPT_insert_timestamp, false))
     Add("-timestamp:0");
 

lld/trunk/MinGW/Options.td

 def verbose: F<"verbose">, HelpText<"Verbose mode">;
 def require_defined: S<"require-defined">,
     HelpText<"Force symbol to be added to symbol table as an undefined one">;
 def require_defined_eq: J<"require-defined=">, Alias<require_defined>;
 
 // LLD specific options
 def _HASH_HASH_HASH : Flag<["-"], "###">,
     HelpText<"Print (but do not run) the commands to run for this compilation">;
+def appcontainer: F<"appcontainer">, HelpText<"Set the appcontainer flag in the executable">;
 def mllvm: S<"mllvm">;
 def pdb: S<"pdb">, HelpText<"Specify output PDB debug information file">;
 def Xlink : J<"Xlink=">, MetaVarName<"<arg>">,
     HelpText<"Pass <arg> to the COFF linker">;
 
 // Alias
 def alias_entry_e: JoinedOrSeparate<["-"], "e">, Alias<entry>;
 def alias_strip_s: Flag<["-"], "s">, Alias<strip_all>;

lld/trunk/test/MinGW/driver.test

 RUN: ld.lld -### -m i386pep foo.o -Llibpath | FileCheck -check-prefix LIBPATH %s
 LIBPATH: -libpath:libpath
 
 RUN: ld.lld -### -m i386pep foo.o --no-insert-timestamp | FileCheck -check-prefix NOTIMESTAMP %s
 RUN: ld.lld -### -m i386pep foo.o --insert-timestamp --no-insert-timestamp | FileCheck -check-prefix NOTIMESTAMP %s
 NOTIMESTAMP: -timestamp:0
 RUN: ld.lld -### -m i386pep foo.o --no-insert-timestamp --insert-timestamp | FileCheck -check-prefix TIMESTAMP %s
 TIMESTAMP-NOT: -timestamp:0
+
+RUN: ld.lld -### -m i386pep foo.o -appcontainer | FileCheck -check-prefix APPCONTAINER %s
+RUN: ld.lld -### -m i386pep foo.o --appcontainer | FileCheck -check-prefix APPCONTAINER %s
+APPCONTAINER: -appcontainer