[clang-tidy] Address post-commit comments

[hokein]

Summary

Also add a test to verify clang-tidy only apply the first alternative
fix.

[hokein]

Cleanup.

[alexfh]

clang-tools-extra/test/clang-tidy/alternative-fixes.cpp

1–7 ↗

(On Diff #195692)

Why can't we use the check_clang_tidy script?

[hokein]

Use check_clang_tidy.

[hokein]

clang-tools-extra/test/clang-tidy/alternative-fixes.cpp

1–7 ↗

(On Diff #195692)

Yes, we do. This was blindly copied from other diagnostic tests.

[alexfh]

There's one more nit. Otherwise good to go.

Thanks!

clang/include/clang/Tooling/Core/Diagnostic.h

97 ↗

(On Diff #195720)

This should be Doxygen's \returns keyword.

[hokein]

fix doxygen comment.

include/clang/Tooling/Core/Diagnostic.h

 
 /// Collection of Diagnostics generated from a single translation unit.
 struct TranslationUnitDiagnostics {
   /// Name of the main source for the translation unit.
   std::string MainSourceFile;
   std::vector<Diagnostic> Diagnostics;
 };
 
-// Get the first fix to apply for this diagnostic.
-// Return nullptr if no fixes attached to the diagnostic.
+/// Get the first fix to apply for this diagnostic.
+/// \returns nullptr if no fixes are attached to the diagnostic.
 const llvm::StringMap<Replacements> *selectFirstFix(const Diagnostic& D);
 
 } // end namespace tooling
 } // end namespace clang
 #endif // LLVM_CLANG_TOOLING_CORE_DIAGNOSTIC_H