Page MenuHomePhabricator

[clang-tidy] Address post-commit comments
ClosedPublic

Authored by hokein on Apr 18 2019, 2:11 AM.

Diff Detail

Repository
rC Clang

Event Timeline

hokein created this revision.Apr 18 2019, 2:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2019, 2:11 AM
Herald added a subscriber: xazax.hun. · View Herald Transcript
hokein updated this revision to Diff 195692.Apr 18 2019, 2:12 AM

Cleanup.

Harbormaster completed remote builds in B30720: Diff 195692.
alexfh added inline comments.Apr 18 2019, 5:51 AM
clang-tools-extra/test/clang-tidy/alternative-fixes.cpp
1–7 ↗(On Diff #195692)

Why can't we use the check_clang_tidy script?

hokein updated this revision to Diff 195720.Apr 18 2019, 6:09 AM
hokein marked an inline comment as done.

Use check_clang_tidy.

hokein added inline comments.Apr 18 2019, 6:09 AM
clang-tools-extra/test/clang-tidy/alternative-fixes.cpp
1–7 ↗(On Diff #195692)

Yes, we do. This was blindly copied from other diagnostic tests.

alexfh accepted this revision.Apr 18 2019, 6:31 AM

There's one more nit. Otherwise good to go.

Thanks!

clang/include/clang/Tooling/Core/Diagnostic.h
97 ↗(On Diff #195720)

This should be Doxygen's \returns keyword.

This revision is now accepted and ready to land.Apr 18 2019, 6:31 AM
hokein updated this revision to Diff 195733.Apr 18 2019, 7:14 AM

fix doxygen comment.

This revision was automatically updated to reflect the committed changes.