This is an archive of the discontinued LLVM Phabricator instance.

[llvm-objdump] Test tabs in disassemble-align.s with a more visible character
ClosedPublic

Authored by MaskRay on Apr 16 2019, 7:53 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

MaskRay created this revision.Apr 16 2019, 7:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 16 2019, 7:53 AM
rupprecht accepted this revision.Apr 16 2019, 8:40 AM

Ok, this helps me see what's going on. Thanks!

test/tools/llvm-objdump/X86/disassemble-align.s
2 ↗(On Diff #195384)

Can you add a comment (here, or maybe below near the actual CHECK lines) that | is to show where the tabs line up?

This revision is now accepted and ready to land.Apr 16 2019, 8:40 AM
MaskRay marked an inline comment as done.Apr 16 2019, 8:56 AM
MaskRay updated this revision to Diff 195396.Apr 16 2019, 8:56 AM

Address review comment

This revision was automatically updated to reflect the committed changes.