Page MenuHomePhabricator

Fix lib/Target/* layering issues by merging InstPrinter into MCTargetDesc
Needs ReviewPublic

Authored by rtrieu on Apr 11 2019, 8:27 PM.
This revision needs review, but there are no reviewers specified.



Move the files in InstPrinter into MCTargetDesc. Update Cmake and LLVMBuild rules as well as update include header locations.

Diff Detail

Event Timeline

rtrieu created this revision.Apr 11 2019, 8:27 PM

I don't understand exactly what the layering issue you're fixing is. Can you elaborate in the commit message?

Phabricator is being too smart for its own good. The main discussion of this change was over on I was creating this as a separate diff so people can see different solutions to the problem.

The layering problem is that InstPrinter and MCTargetDesc depend on each other creating a circular dependency (for some backends). One of the solutions was to merge InstPrinter and MCTargetDesc into one library, which is detailed in this diff.