Page MenuHomePhabricator

Adjusting libc++ std::list formatter to act better with pointers and references and adding a test to cover a previous related fix
ClosedPublic

Authored by shafik on Apr 11 2019, 2:53 PM.

Details

Summary

This previous fix https://github.com/llvm-mirror/lldb/commit/5469bda296c183d1b6bf74597c88c9ed667b3145 did not have a test since we did not have a reproducer.

This is related to how formatters deal with pointers and references. The added tests both the new behavior and covers the previous bug fix as well.

Diff Detail

Repository
rL LLVM

Event Timeline

shafik created this revision.Apr 11 2019, 2:53 PM
This revision is now accepted and ready to land.Apr 19 2019, 10:57 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 24 2019, 10:36 AM