This is an archive of the discontinued LLVM Phabricator instance.

[ConstantRange] Add unsignedMulMayOverflow()
ClosedPublic

Authored by nikic on Apr 11 2019, 12:10 PM.

Details

Summary

Same as as other overflow checking methods, but for unsigned mul... in this case there is no cheap overflow criterion, so using umul_ov for the implementation.

Diff Detail

Event Timeline

nikic created this revision.Apr 11 2019, 12:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 11 2019, 12:10 PM
lebedev.ri accepted this revision.Apr 11 2019, 12:38 PM

LG modulo all the typos..

llvm/unittests/IR/ConstantRangeTest.cpp
1581

Uhm, i should have noticed this sooner, but then i make typos all the time.
Here and *everywhere*, s/Exhautive/Exhaustive/.

This revision is now accepted and ready to land.Apr 11 2019, 12:38 PM
This revision was automatically updated to reflect the committed changes.
nikic marked 2 inline comments as done.Apr 11 2019, 2:10 PM
nikic added inline comments.
llvm/unittests/IR/ConstantRangeTest.cpp
1581

Gah, I keep making this typo... Fixed in rL358227.