Fix junk content handling within GDBRemoteCommunication::CheckForPacket.

[ovyalov]

Summary

Fix junk content handling within GDBRemoteCommunication::CheckForPacket:

1. Avoid removing of an extra symbol from m_bytes.
2. Iterate over m_bytes until useful content is found.

[apepper]

It looks fine to me.

[clayborg]

Can you redo this patch and only change stuff that is changed? There is so much whitespace change here I can't tell what little things have changed

[ovyalov]

Reran diff as "git diff --ignore-space-change" in order to eliminate spaces - please take another look.

Thank you!

[clayborg]

Looks good.

[ovyalov]

Thank you for reviews!

[ovyalov]

Shawn, could you submit this change?

[sbest]

Hey Oleksiy, can you rebase the patch for me, I got HUNK Failed when applying. It could be related to the whitespace stripping you did for Greg. Also, I notice something weird with the block of code you wrapped with the while() loop. It appears to be indented only 2 spaces instead of 4.

[ovyalov]

Hi Shawn,

I rebased the patch - could you give it another try?

Thanks.

[Eugene.Zelenko]

Committed in r220983.

source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp

         // it off with an invalid value that is the same as the current
         // index.
         size_t content_start = 0;
-        size_t content_length = 0;
+        size_t content_length = std::string::npos;
         size_t total_length = 0;
         size_t checksum_idx = std::string::npos;
 
+        while (!m_bytes.empty() && content_length == std::string::npos)
+        {
           switch (m_bytes[0])
           {
               case '+':       // Look for ack

                       }
                       if (log)
                           log->Printf ("GDBRemoteCommunication::%s tossing %u junk bytes: '%.*s'",
-                                     __FUNCTION__, idx, idx, m_bytes.c_str());
-                    m_bytes.erase(0, idx);
+                                       __FUNCTION__, idx - 1, idx - 1, m_bytes.c_str());
+                      m_bytes.erase(0, idx - 1);
                   }
                   break;
           }
+        }
 
         if (content_length == std::string::npos)
         {