Page MenuHomePhabricator

Fix junk content handling within GDBRemoteCommunication::CheckForPacket.
ClosedPublic

Authored by ovyalov on Oct 30 2014, 3:19 PM.

Details

Summary

Fix junk content handling within GDBRemoteCommunication::CheckForPacket:

  1. Avoid removing of an extra symbol from m_bytes.
  2. Iterate over m_bytes until useful content is found.

Diff Detail

Event Timeline

ovyalov updated this revision to Diff 15585.Oct 30 2014, 3:19 PM
ovyalov retitled this revision from to Fix junk content handling within GDBRemoteCommunication::CheckForPacket..
ovyalov updated this object.
ovyalov edited the test plan for this revision. (Show Details)
ovyalov added reviewers: clayborg, apepper.
ovyalov added a subscriber: Unknown Object (MLST).
apepper edited edge metadata.Oct 30 2014, 4:02 PM

It looks fine to me.

clayborg requested changes to this revision.Oct 30 2014, 4:19 PM
clayborg edited edge metadata.

Can you redo this patch and only change stuff that is changed? There is so much whitespace change here I can't tell what little things have changed

This revision now requires changes to proceed.Oct 30 2014, 4:19 PM
ovyalov updated this revision to Diff 15593.Oct 30 2014, 4:35 PM
ovyalov edited edge metadata.

Reran diff as "git diff --ignore-space-change" in order to eliminate spaces - please take another look.

Thank you!

clayborg accepted this revision.Oct 30 2014, 4:42 PM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Oct 30 2014, 4:42 PM

Thank you for reviews!

Shawn, could you submit this change?

sbest edited edge metadata.Oct 30 2014, 6:24 PM

Hey Oleksiy, can you rebase the patch for me, I got HUNK Failed when applying. It could be related to the whitespace stripping you did for Greg. Also, I notice something weird with the block of code you wrapped with the while() loop. It appears to be indented only 2 spaces instead of 4.

ovyalov updated this revision to Diff 15602.Oct 30 2014, 10:16 PM
ovyalov edited edge metadata.

Hi Shawn,

I rebased the patch - could you give it another try?

Thanks.

Eugene.Zelenko added a subscriber: Eugene.Zelenko.

Committed in r220983.