This is an archive of the discontinued LLVM Phabricator instance.

Fix missing arguments in tutorial
ClosedPublic

Authored by MCSH on Apr 6 2019, 3:32 PM.

Details

Summary

In tutorial "8. Kaleidoscope: Compiling to Object Code" a call to TargetMachine->addPassesToEmitFile(pass, dest, FileType) is missing nullptr as its 3rd value.

Diff Detail

Event Timeline

MCSH created this revision.Apr 6 2019, 3:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2019, 3:32 PM
hans accepted this revision.Apr 10 2019, 6:02 AM

Thanks! This matches the code in llvm/examples/Kaleidoscope/Chapter8/toy.cpp

Do you have commit access, or would you like me to commit it for you?

This revision is now accepted and ready to land.Apr 10 2019, 6:02 AM
MCSH added a comment.Apr 11 2019, 11:34 AM

I don't think I have access. Would you please take care of it?

Thanks in advance

This revision was automatically updated to reflect the committed changes.