Page MenuHomePhabricator

[TSan][libdispatch] Fix test
AbandonedPublic

Authored by yln on Apr 5 2019, 3:55 PM.

Details

Reviewers
kubamracek
Summary

We have barrier_init(..., 2), but 4 calls to barrier_wait.

I think in this test we want to show that dispatch_barrier synchronizes
with all blocks before and after on the same queue. So we need to use
the same queue (bgq -> q).

Event Timeline

yln created this revision.Apr 5 2019, 3:55 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 5 2019, 3:55 PM
Herald added subscribers: llvm-commits, Restricted Project, kubamracek. · View Herald Transcript
kubamracek added inline comments.Apr 5 2019, 4:10 PM
compiler-rt/test/tsan/Darwin/gcd-barrier.mm
31

How is this a problem? barrier_wait can be used multiple times and it will only trigger for every N times it's waited

yln abandoned this revision.Apr 5 2019, 4:35 PM