This is an archive of the discontinued LLVM Phabricator instance.

[test-suite] litsupport/modules/microbenchmark.py: propagate perf file to the microbenchmarks
AbandonedPublic

Authored by lebedev.ri on Apr 5 2019, 1:02 PM.

Details

Summary

Currently, for the microbenchmarks, the microbenchmark module is enabled,
and timeit module is disabled. Which means, the actual microbenchmark executable
will not have exec_time metric, and will not be present in the reports.
But the perf module only knows about that main run, it doesn't know anything
about the micro-benchmark results. So it only sets the profile metric for that
main run. Which won't be present in the reports. So it is completely impossible
to view the perf profiles...

Depends on D60336

Diff Detail

Repository
rL LLVM

Event Timeline

lebedev.ri created this revision.Apr 5 2019, 1:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2019, 1:02 PM
lebedev.ri marked an inline comment as done.Apr 10 2019, 7:35 AM
lebedev.ri added inline comments.
litsupport/modules/microbenchmark.py
43

Ah yes, this should be if hasattr(context, 'profilefile'):, will fix.

Properly check that said attr exists.

lebedev.ri abandoned this revision.Jun 26 2019, 11:01 AM