This is an archive of the discontinued LLVM Phabricator instance.

[gn] Make -no-exceptions flag a config
ClosedPublic

Authored by phosek on Apr 5 2019, 11:29 AM.

Details

Summary

This allows it to be disabled for targets that need exceptions
like libunwind, libc++abi and libc++.

Diff Detail

Event Timeline

phosek created this revision.Apr 5 2019, 11:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2019, 11:29 AM
thakis accepted this revision.Apr 5 2019, 11:44 AM
This revision is now accepted and ready to land.Apr 5 2019, 11:44 AM
This revision was automatically updated to reflect the committed changes.
thakis added inline comments.Apr 9 2019, 6:55 AM
llvm/trunk/utils/gn/build/BUILD.gn
67 ↗(On Diff #193933)

This broke things on Windows. Do you know if /EHSs-c- should be in no_exceptions on Windows too? For now I'll just put fno-exceptions in a host_os != "win" block like it used to be, but maybe that isn't quite the right fix.