This is an archive of the discontinued LLVM Phabricator instance.

Updating Chromium's Java import order
ClosedPublic

Authored by SamMaier on Apr 3 2019, 8:12 AM.

Reviewers

Commits

Summary

Adding in androidx as another import group.

Thanks!

(Test?)

This revision is now accepted and ready to land.Apr 3 2019, 8:17 AM

In D60203#1453313, @thakis wrote:

Thanks!

(Test?)

We currently don't have tests for Chromium's specific Java import order. The tests for Java import order use their own order. Should this change?

Ah, ok. Probably want to add tests at some point, but I'll land this as-is for now then.

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

Format/

13 lines

Context not available.
	// See styleguide for import groups:	// See styleguide for import groups:
	// https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md#Import-Order	// https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md#Import-Order
	ChromiumStyle.JavaImportGroups = {	ChromiumStyle.JavaImportGroups = {
	"android", "com", "dalvik",	"android",
	"junit", "org", "com.google.android.apps.chrome",	"androidx",
	"org.chromium", "java", "javax",	"com",
		"dalvik",
		"junit",
		"org",
		"com.google.android.apps.chrome",
		"org.chromium",
		"java",
		"javax",
	};	};
	ChromiumStyle.SortIncludes = true;	ChromiumStyle.SortIncludes = true;
	} else if (Language == FormatStyle::LK_JavaScript) {	} else if (Language == FormatStyle::LK_JavaScript) {
Context not available.