Page MenuHomePhabricator

Add an optional list of blocks to avoid when looking for a path in isPotentiallyReachable.
ClosedPublic

Authored by nicholas on Apr 1 2019, 11:54 AM.

Details

Summary

Add an optional list of blocks to avoid when looking for a path in isPotentiallyReachable.

The leads to some ambiguous overloads, so update three callers.

Diff Detail

Repository
rL LLVM

Event Timeline

nicholas created this revision.Apr 1 2019, 11:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2019, 11:54 AM
asbirlea accepted this revision.Apr 1 2019, 5:05 PM

LGTM, modulo one nit. Thank you!

llvm/lib/Analysis/CFG.cpp
168 ↗(On Diff #193144)

Could you comment the reasoning behind this for those not familiar with this code, to make it clear why this makes sense?
e.g.: "If Outer is found, we skip straight to the exit blocks below. Set it to nullptr here, to go the slow route and process BB's successors."

This revision is now accepted and ready to land.Apr 1 2019, 5:05 PM
This revision was automatically updated to reflect the committed changes.